<font size=2 face="sans-serif">Agreed that any -1's should require a suggestion
for a way to resolve the issue. I haven't seen people -1'ing without
suggestions for improvement though. I think, generally, people help
explain why a change is needed.<br>
</font>
<br><font size=3><b><i><br>
<br>
Jay S. Bryant</i></b><i><br>
Linux Developer - <br>
OpenStack Enterprise Edition</i><br>
</font><img src=cid:_2_0CA8BB780CA8B7400070DC0886257C20 alt="OpenStack Community Logo"><font size=3><br>
Department 7YLA, Building 015-2, Office E125, Rochester, MN<br>
Telephone: (507) 253-4270, FAX (507) 253-6410<br>
TIE Line: 553-4270<br>
E-Mail: jsbryant@us.ibm.com<br>
--------------------------------------------------------------------<br>
All the world's a stage and most of us are desperately unrehearsed.<br>
-- Sean
O'Casey<br>
--------------------------------------------------------------------</font>
<br>
<br>
<br>
<br><font size=1 color=#5f5f5f face="sans-serif">From:
</font><font size=1 face="sans-serif">Ben Nemec <openstack@nemebean.com></font>
<br><font size=1 color=#5f5f5f face="sans-serif">To:
</font><font size=1 face="sans-serif">openstack-dev@lists.openstack.org,
</font>
<br><font size=1 color=#5f5f5f face="sans-serif">Date:
</font><font size=1 face="sans-serif">11/11/2013 02:05 PM</font>
<br><font size=1 color=#5f5f5f face="sans-serif">Subject:
</font><font size=1 face="sans-serif">Re: [openstack-dev]
[qa] Policy on spelling and grammar</font>
<br>
<hr noshade>
<br>
<br>
<br><tt><font size=2>On 2013-11-11 13:28, Tim Bell wrote:<br>
> As a speaker of the Queen's English, I find flavor to be incorrect.<br>
> Does that mean I can -1 any patch that does not use flavour ?<br>
> <br>
> At CERN, we are working with 130 countries in a single community.
The<br>
> value of the contribution of non-english speakers far exceeds the<br>
> occasional misunderstandings.<br>
> <br>
> Giving grammar/spellings -1 excludes major sections of the community<br>
> from contribution.<br>
> <br>
> As our aim is meritocracy (in python, computer architecture and design<br>
> rather than spelling), I'd propose<br>
> <br>
> - If someone identifies a need for clarification/correction as part
of<br>
> a review, they also submit the replacement text rather than just -1.<br>
> - The submitter incorporates that change into a patch<br>
<br>
Agreed. Whenever possible, a grammar/spelling -1 should include <br>
proposed alternatives (I say whenever possible because I've -1'd a few
<br>
changes where the docstrings were incomprehensible to me, so I couldn't
<br>
provide a better alternative as I wasn't sure what they were trying to
<br>
say :-).<br>
<br>
-Ben<br>
<br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
OpenStack-dev@lists.openstack.org<br>
</font></tt><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev"><tt><font size=2>http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</font></tt></a><tt><font size=2><br>
<br>
</font></tt>
<br>