<table cellspacing="0" cellpadding="0" border="0"><tr><td valign="top">Hi all, <br/><br/>Adding a message for new comers is a good idea. <br/>I am a new Horizon contributor, some of my fixes have been merged (thanks to Upstream University :-) and reviewers of course) but I still hesitate to do code review. To my mind, it is reserved to "known" developpers whose opinion matters... <br/><br/>- Romain</td></tr></table> <div id="_origMsg_">
<div>
<br />
<div>
<div style="font-size:0.9em">
<hr size="1">
<b>
<span style="font-weight:bold">From:</span>
</b>
Stefano Maffulli <stefano@openstack.org>; <br>
<b>
<span style="font-weight:bold">To:</span>
</b>
<openstack-dev@lists.openstack.org>; <br>
<b>
<span style="font-weight:bold">Subject:</span>
</b>
[openstack-dev] welcoming new committers (was Re: When is it okay for submitters to say 'I don't want to add tests' ?) <br>
<b>
<span style="font-weight:bold">Sent:</span>
</b>
Thu, Oct 31, 2013 6:49:18 PM <br>
</div>
<br>
<table cellspacing="0" cellpadding="0" border="0">
<tbody>
<tr>
<td valign="top">On 10/31/2013 07:05 AM, Kyle Mestery (kmestery) wrote:<BR>[...]<BR>> If we want to grow the committer base and help people to become<BR>> better reviewers, taking the time to show them the ropes is part of<BR>> the game.<BR><BR>hijacking the thread using Kyle's comment as an excuse.<BR><BR>It's not an 'if' but a 'since': since we are growing the committer base<BR>at an incredible pace we should help them become also good reviewers as<BR>rapidly possible.<BR><BR>One thing I already mentioned and I'll start doing this week in the<BR>weekly Newsletter is to give a shoutout to those that do their first<BR>review this week.<BR><BR>Another idea that Tom suggested is to use gerrit automation to send back<BR>to first time committers something in addition to the normal 'your patch<BR>is waiting for review' message. The message could be something like:<BR><BR>> thank you for your first
contribution to OpenStack. Your patch will<BR>> now be tested automatically by OpenStack testing frameworks and once<BR>> the automatic tests pass, it will be reviewed by other friendly<BR>> developers. They will give you comments and may require you to refine<BR>> it.<BR>> <BR>> Nobody gets his patch approved at first try so don't be concerned<BR>> when someone will require you to do more iterations.<BR>> <BR>> Patches usually take 3 to 7 days to be approved so be patient and be<BR>> available on IRC to ask and answer questions about your work. The<BR>> more you participate in the community the more rewarding it is for<BR>> you. You may also notice that the more you get to know people and get<BR>> to be known, the faster your patches will be reviewed and eventually<BR>> approved. Get to know others and be known by doing code reviews:<BR>> anybody can and should do it.<BR><BR>With links to the wiki for more
details, of course. This sort of<BR>messaging may help all the people that contribute tactically, those that<BR>are asked by their manager to land a patch in here and are simply<BR>lightly involved (not committed) in OpenStack. These are the ones that<BR>may have an incorrect perception of how easy it is to have patches<BR>landed in OpenStack as opposed to other large projects, like the kernel<BR>or android and complain about our time to traverse the review system.<BR><BR>What do you think? How can we instruct gerrit to do this?<BR><BR>/stef<BR><BR>PS I put the text on<BR><a href="https://etherpad.openstack.org/p/welcome-new-committers" target=_blank >https://etherpad.openstack.org/p/welcome-new-committers</a> for refinements.<BR><BR>-- <BR>Ask and answer questions on <a href="https://ask.openstack.org" target=_blank >https://ask.openstack.org</a><BR><BR>_______________________________________________<BR>OpenStack-dev mailing list<BR><a
ymailto="mailto:OpenStack-dev@lists.openstack.org" href="javascript:return">OpenStack-dev@lists.openstack.org</a><BR><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target=_blank >http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><BR></td>
</tr>
</tbody>
</table>
</div>
</div>
</div>