<p dir="ltr"><br>
On Oct 30, 2013 9:10 AM, "Robert Collins" <<a href="mailto:robertc@robertcollins.net">robertc@robertcollins.net</a>> wrote:<br>
><br>
> Hi, like most OpenStack projects we need to keep the core team up to<br>
> date: folk who are not regularly reviewing will lose context over<br>
> time, and new folk who have been reviewing regularly should be trusted<br>
> with -core responsibilities.<br>
><br>
> In this months review:<br>
> - James Slagle for -core<br>
> - Arata Notsu to be removed from -core<br>
> - Devananda van der veen to be removed from -core<br>
><br>
> Existing -core members are eligible to vote - please indicate your<br>
> opinion on each of the three changes above in reply to this email.<br>
> James, please let me know if you're willing to be in tripleo-core.<br>
> Arata, Devananda, if you are planning on becoming substantially more<br>
> active in TripleO reviews in the short term, please let us know.<br>
><br>
> My approach to this caused some confusion last time, so I'll try to<br>
> frame this better :) - I'm going to talk about stats here, but they<br>
> are only part of the picture : folk that aren't really being /felt/ as<br>
> effective reviewers won't be asked to take on -core responsibility,<br>
> and folk who are less active than needed but still very connected to<br>
> the project may still keep them : it's not pure numbers.<br>
><br>
> Also, it's a vote: that is direct representation by the existing -core<br>
> reviewers as to whether they are ready to accept a new reviewer as<br>
> core or not. This mail from me merely kicks off the proposal for any<br>
> changes.<br></p>
<p dir="ltr">As I am not core, no vote on the three people above. But wanted to say I like the model outlined in this email.<br>
><br>
> But, the metrics provide an easy fingerprint - they are a useful tool<br>
> to avoid bias (e.g. remembering folk who are just short-term active) -<br>
> human memory can be particularly treacherous - see 'Thinking, Fast and<br>
> Slow'.<br>
><br>
> With that prelude out of the way:<br>
><br>
> Please see Russell's excellent stats:<br>
> <a href="http://russellbryant.net/openstack-stats/tripleo-reviewers-30.txt">http://russellbryant.net/openstack-stats/tripleo-reviewers-30.txt</a><br>
> <a href="http://russellbryant.net/openstack-stats/tripleo-reviewers-90.txt">http://russellbryant.net/openstack-stats/tripleo-reviewers-90.txt</a><br>
><br>
> For joining and retaining core I look at the 90 day statistics; folk<br>
> who are particularly low in the 30 day stats get a heads up so they<br>
> aren't caught by surprise.<br>
><br>
> Our merger with Tuskar is still fairly recent; folk from the Tuskar<br>
> project who are reviewing widely within TripleO are still low on the<br>
> mechanical stats - I think we should keep them as -core for another<br>
> month unconditionally, after which there will be three months of<br>
> history to inform us about broad activity.<br>
><br>
> 90 day active-enough stats:<br>
><br>
> +--------------------------+-----------------------------------+----------------+<br>
> | Reviewer | Reviews -2 -1 +1 +2 +/- % |<br>
> Disagreements* |<br>
> +--------------------------+-----------------------------------+----------------+<br>
> | lifeless ** | 457 17 169 6 265 59.3% | 9<br>
> ( 3.3%) |<br>
> | clint-fewbar ** | 431 2 81 1 347 80.7% | 10<br>
> ( 2.9%) |<br>
> | cmsj ** | 361 1 28 0 332 92.0% | 14<br>
> ( 4.2%) |<br>
> | derekh ** | 150 0 30 13 107 80.0% | 3<br>
> ( 2.5%) |<br>
> | slagle | 98 0 20 78 0 79.6% | 10<br>
> ( 12.8%) |<br>
><br>
> James is coming along very well. I'd like to see a little more<br>
> critical analysis in his reviews, but I think his standard is high<br>
> enough now to carry the weight of -core.<br>
><br>
> And the 90 day not-active-enough status:<br>
><br>
> | arata776 ** | 9 0 2 0 7 77.8% | 0<br>
> ( 0.0%) |<br>
> | devananda ** | 6 0 0 0 6 100.0% | 0<br>
> ( 0.0%) |<br>
><br>
> Both Arata and Devananda are active in OpenStack as a whole, but I<br>
> think they're not tracking the TripleO project code changes closely<br>
> enough to wearing the -core mantle. I'd be delighted if they want to<br>
> rejoin as core - perhaps even after a shorter than usual ramp up<br>
> period if they get stuck in.</p>
<p dir="ltr">We have this in nova, ex-cores get fast tracked if they start reviewing again. As they can catch up on context quicker and have already proven that there reviews are on par with what is expected from core.</p>
<p dir="ltr">><br>
> Now, 30 day history - this is the heads up for folk...<br>
><br>
> Folk that are on track to retain/ be asked to be -core:<br>
><br>
> | lifeless ** | 234 11 80 5 138 61.1% | 8 ( 5.6%) |<br>
> | clint-fewbar ** | 218 1 48 0 169 77.5% | 6 ( 3.6%) |<br>
> | cmsj ** | 180 1 9 0 170 94.4% | 4 ( 2.4%) |<br>
> | derekh ** | 96 0 10 1 85 89.6% | 0 ( 0.0%) |<br>
> | slagle | 70 0 13 57 0 81.4% | 7 ( 12.3%) |<br>
> | lsmola ** | 53 1 14 16 22 71.7% | 4 ( 10.5%) |<br>
> | rpodolyaka | 49 0 15 34 0 69.4% | 4 ( 11.8%) |<br>
> | jogo | 45 0 5 40 0 88.9% | 2 ( 5.0%) |<br>
> | ifarkas ** | 39 0 5 4 30 87.2% | 3 ( 8.8%) |<br>
> | jistr ** | 36 0 10 7 19 72.2% | 2 ( 7.7%) |<br>
> | tzumainn ** | 34 0 9 2 23 73.5% | 1 ( 4.0%) |<br>
> | ghe.rivero | 32 0 5 27 0 84.4% | 5 ( 18.5%) |<br>
><br>
> -core that are not keeping up...:<br>
> | tomas-8c8 ** | 23 0 5 1 17 78.3% | 3 ( 16.7%) |<br>
> | pblaho ** | 19 0 2 3 14 89.5% | 1 ( 5.9%) |<br>
> | marios ** | 14 0 1 12 1 92.9% | 1 ( 7.7%) |<br>
> | jomara ** | 10 0 0 0 10 100.0% | 1 ( 10.0%) |<br>
> | arata776 ** | 9 0 2 0 7 77.8% | 0 ( 0.0%) |<br>
> | jtomasek ** | 7 0 0 0 7 100.0% | 0 ( 0.0%) |<br>
> | devananda ** | 5 0 0 0 5 100.0% | 0 ( 0.0%) |<br>
> | jprovazn ** | 3 0 0 3 0 100.0% | 1 ( 33.3%) |<br>
><br>
> Please remember - the stats are just an entry point to a more detailed<br>
> discussion about each individual, and I know we all have a bunch of<br>
> work stuff, particularly in the lead up to the summit!<br>
><br>
> I'm using the fairly simple metric of 'average at least one review a<br>
> day' as a proxy for 'sees enough of the code and enough discussion of<br>
> the code to be an effective reviewer'. The one review a day thing I<br>
> derive thusly:<br>
> - reading a single patch a day is a low commitment to ask for<br>
> - if you don't have time to do that, you will get stale quickly -<br>
> you'll only see<br>
> about 20% of the code changes going on (we're doing about 5 commits<br>
> a day and hopefully not slowing down!)<br>
><br>
> Cheers,<br>
> Rob<br>
><br>
> --<br>
> Robert Collins <<a href="mailto:rbtcollins@hp.com">rbtcollins@hp.com</a>><br>
> Distinguished Technologist<br>
> HP Converged Cloud<br>
><br>
> _______________________________________________<br>
> OpenStack-dev mailing list<br>
> <a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</p>