<div dir="ltr">Hi,<div><br></div><div>1. It's not necessary to abandon your patch if it has failed jenkins tests.</div><div>2. Before submitting the new patch for review it's better to run unit tests (tox -epy27) and pep8 check (tox -epep8)</div>
<div>Integration testing is being done by <font color="#000000"><font face="Arial Unicode MS, Arial, sans-serif">check-tempest-devstack-vm-neut</font>ron* suites and some of them fail from time to time due to other known bugs.</font></div>
<div><font color="#000000">In case of such failure just put 'recheck no bug' in general review comment, (or 'recheck bug xxxxxx' if you know which bug you are hitting). Sometimes integration test failures are caused by the patch itself, in this case you need to analyze the logs and fix the code.</font></div>
<div><font color="#000000">But I believe it's not your case.</font></div><div><font color="#000000"><br></font></div><div><font color="#000000">Thanks,</font></div><div><font color="#000000">Eugene.</font></div></div>
<div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Oct 23, 2013 at 9:38 AM, S Sridhar <span dir="ltr"><<a href="mailto:sridharas@outlook.com" target="_blank">sridharas@outlook.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div dir="ltr">Hi All,<div><br></div><div>I posted a review earlier - <a href="https://review.openstack.org/#/c/53160/" style="font-size:12pt" target="_blank">https://review.openstack.org/#/c/53160/</a>, which failed Jenkins test. I realized that changes required in other files too. <span style="font-size:12pt">I 'Abandoned Changes' so that I can post review set again. I have made the changes now, but want to test them before sending for review. </span></div>
<div><span style="font-size:12pt"><br></span></div><div><span style="font-size:12pt">It is suggested in </span><a href="https://wiki.openstack.org/wiki/GerritWorkflow" style="font-size:12pt" target="_blank">https://wiki.openstack.org/wiki/GerritWorkflow</a> to run 'tox' before checking in. Is this enough or there are any other steps I need to follow for unit testing? </div>
<div><br></div><div>Please suggest.</div><div><br></div><div>Regards</div><span class="HOEnZb"><font color="#888888"><div>Sridhar</div> </font></span></div></div>
<br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>