<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">
<div apple-content-edited="true"><br class="Apple-interchange-newline">
</div>
<br>
<div>
<div>On Oct 16, 2013, at 05:48 , Dan Smith <<a href="mailto:dms@danplanet.com">dms@danplanet.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<blockquote type="cite">The last thing that OpenStack needs ANY more help with is velocity. I<br>
mean, let's be serious - we land WAY more patches in a day than is<br>
even close to sane.<br>
</blockquote>
<br>
Thanks for saying this -- it doesn't get said enough. I find it totally<br>
amazing that we're merging 34 changes in a day (yesterday) which is like<br>
170 per work week (just on nova). More amazing is that we're talking<br>
about how to make it faster all the time. It's definitely the fastest<br>
moving extremely complex thing I can recall working on.<br>
<br>
</blockquote>
<div><br>
</div>
<div>Dan, nobody puts into discussion how good the work that you guys are doing is. You guys are doing an amazing job, that's unquestionable. </div>
<div><br>
</div>
<div>The problem is that the review team, in the way in which it is structured today, simply does not scale with the review load (which is quite funny in a project which is all about scalability :-)).</div>
<div><br>
</div>
<div>Here's a quick analysys over the 90 days Nova review stats published by Russell: <a href="http://russellbryant.net/openstack-stats/nova-reviewers-90.txt">http://russellbryant.net/openstack-stats/nova-reviewers-90.txt</a></div>
<div><br>
</div>
<div>Roughly 2/3 of the reviews are done by 20 people, with the top 10 getting close to 50%.</div>
<div>Let's say that we provide out of our sub-team 1 additional Nova core dev that will perform in the top 10, which averages 521 reviewes, 4,6% of the total. </div>
<div>This would reduce our stale review queue time by 5%, which is quite far from a practical improvement over the current mess IMO. </div>
<div><br>
</div>
<div>The picture changes if you put this additional resource to do reviews mostly on our sub-project code, but at that point I don't see the difference from having somebody with +2 rights on the driver sub-tree only.</div>
<div><br>
</div>
<div>This example applies to any sub-project of course, not only the Hyper-V driver.</div>
<div><br>
</div>
<div><br>
</div>
<div>(I hope that the table formatting will come out decently in the ML email, if not please find the data here: <a href="http://paste.openstack.org/show/48539/">http://paste.openstack.org/show/48539/</a>)</div>
<div><br>
</div>
<div>
<table border="0" cellpadding="0" cellspacing="0" width="390" style="border-collapse:
collapse;width:390pt">
<!--StartFragment--><colgroup><col width="65" span="3" style="width:65pt"><col width="65" style="width:65pt"><col width="65" span="2" style="width:65pt"></colgroup>
<tbody>
<tr height="15" style="height:15.0pt">
<td height="15" class="xl64" width="65" style="height:15.0pt;width:65pt">Reviewer</td>
<td class="xl64" width="65" style="width:65pt">Core</td>
<td class="xl64" width="65" style="width:65pt">Reviews</td>
<td class="xl65" width="65" style="width:65pt">% over total</td>
<td class="xl64" width="65" style="width:65pt">Partials</td>
<td width="65" style="width:65pt"></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">russellb</td>
<td>yes</td>
<td align="right">888</td>
<td class="xl63" align="right">7,84%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">garyk</td>
<td></td>
<td align="right">856</td>
<td class="xl63" align="right">7,55%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">jogo</td>
<td>yes</td>
<td align="right">475</td>
<td class="xl63" align="right">4,19%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">mikalstill</td>
<td>yes</td>
<td align="right">450</td>
<td class="xl63" align="right">3,97%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">danms</td>
<td>yes</td>
<td align="right">447</td>
<td class="xl63" align="right">3,94%</td>
<td class="xl66" align="right">23,55%</td>
<td>TOP 5</td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">ndipanov</td>
<td>yes</td>
<td align="right">432</td>
<td class="xl63" align="right">3,81%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">klmitch</td>
<td>yes</td>
<td align="right">429</td>
<td class="xl63" align="right">3,79%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">cbehrens</td>
<td>yes</td>
<td align="right">360</td>
<td class="xl63" align="right">3,18%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">johngarbutt</td>
<td>yes</td>
<td align="right">351</td>
<td class="xl63" align="right">3,10%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">cyeoh-0</td>
<td>yes</td>
<td align="right">327</td>
<td class="xl63" align="right">2,89%</td>
<td class="xl66" align="right">44,25%</td>
<td>TOP 10</td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">markmc</td>
<td>yes</td>
<td align="right">304</td>
<td class="xl63" align="right">2,68%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">alaski</td>
<td>yes</td>
<td align="right">289</td>
<td class="xl63" align="right">2,55%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">mriedem</td>
<td></td>
<td align="right">270</td>
<td class="xl63" align="right">2,38%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">cerberus</td>
<td>yes</td>
<td align="right">266</td>
<td class="xl63" align="right">2,35%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">dripton</td>
<td></td>
<td align="right">261</td>
<td class="xl63" align="right">2,30%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">berrange</td>
<td>yes</td>
<td align="right">251</td>
<td class="xl63" align="right">2,21%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">jhesketh</td>
<td></td>
<td align="right">250</td>
<td class="xl63" align="right">2,21%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">philip-day</td>
<td></td>
<td align="right">250</td>
<td class="xl63" align="right">2,21%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">xuhj</td>
<td></td>
<td align="right">237</td>
<td class="xl63" align="right">2,09%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">belliott</td>
<td>yes</td>
<td align="right">212</td>
<td class="xl63" align="right">1,87%</td>
<td class="xl66" align="right">67,10%</td>
<td>TOP 20</td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">guohliu</td>
<td></td>
<td align="right">201</td>
<td class="xl63" align="right">1,77%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">boris-42</td>
<td></td>
<td align="right">170</td>
<td class="xl63" align="right">1,50%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">sdague</td>
<td>yes</td>
<td align="right">164</td>
<td class="xl63" align="right">1,45%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">p-draigbrady</td>
<td>yes</td>
<td align="right">130</td>
<td class="xl63" align="right">1,15%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">vishvananda</td>
<td>yes</td>
<td align="right">123</td>
<td class="xl63" align="right">1,09%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">tracyajones</td>
<td></td>
<td align="right">112</td>
<td class="xl63" align="right">0,99%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">JayLau</td>
<td></td>
<td align="right">109</td>
<td class="xl63" align="right">0,96%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">hartsocks</td>
<td></td>
<td align="right">108</td>
<td class="xl63" align="right">0,95%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">arosen</td>
<td></td>
<td align="right">106</td>
<td class="xl63" align="right">0,94%</td>
<td></td>
<td></td>
</tr>
<tr height="15" style="height:15.0pt">
<td height="15" style="height:15.0pt">dims-v</td>
<td></td>
<td align="right">101</td>
<td class="xl63" align="right">0,89%</td>
<td class="xl66" align="right">78,79%</td>
<td>TOP 30</td>
</tr>
<!--EndFragment-->
</tbody>
</table>
</div>
<div><br>
</div>
<div></div>
<div><br>
</div>
<div><br>
</div>
<br>
<blockquote type="cite">
<blockquote type="cite">We MUST continue to be vigilent in getting people to care about more<br>
than their specific part, or else this big complex mess is going to come<br>
crashing down around us.<br>
</blockquote>
<br>
I totally agree.<br>
<br>
--Dan<br>
<br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev<br>
</blockquote>
</div>
<br>
</body>
</html>