<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">
<div apple-content-edited="true"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><br>
</span></div>
<div>
<div>On Oct 15, 2013, at 18:14 , Duncan Thomas <<a href="mailto:duncan.thomas@gmail.com">duncan.thomas@gmail.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">On 11 October 2013 15:41, Alessandro Pilotti<br>
<<a href="mailto:apilotti@cloudbasesolutions.com">apilotti@cloudbasesolutions.com</a>> wrote:<br>
<blockquote type="cite">Current reviews require:<br>
<br>
+1 "de facto" driver X mantainer(s)<br>
+2 core reviewer<br>
+2A core reviewer<br>
<br>
While with the proposed scenario we'd get to a way faster route:<br>
<br>
+2 driver X mantainer<br>
+2A another driver X mantainer or a core reviewer<br>
<br>
This would make a big difference in terms of review time.<br>
</blockquote>
<br>
Unfortunately I suspect it would also lead to a big difference in<br>
review quality, and not in a positive way. The things that are<br>
important / obvious to somebody who focuses on one driver are totally<br>
different, and often far more limited, than the concerns of somebody<br>
who reviews many drivers and core code changes.<br>
</blockquote>
<div><br>
</div>
<div>Although the eyes of somebody which comes from a different domain bring usually additional points of views and befits, this was not particularly the case for what our driver is concerned. As I already wrote, almost all the reviews so far have been related
to unit tests or minor formal corrections. </div>
<div><br>
</div>
<div>I disagree on the "far more limited": driver devs (at least in our case), have to work on a wider range of projects beside Nova (e.g.: Neutron, Cinder, Ceilometer and outside proper OpenStack OpenVSwitch and Crowbar, to name the most relevant cases). </div>
<div><br>
</div>
<div><br>
</div>
<div><br>
</div>
<br>
<blockquote type="cite"><br>
-- <br>
Duncan Thomas<br>
<br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev<br>
</blockquote>
</div>
<br>
</body>
</html>