<font size=2 face="sans-serif">Sorry to pile on, but:</font>
<br>
<br><font size=2 face="sans-serif">"</font><font size=3>this was not
particularly the case for what our driver is concerned. As I already wrote,
almost all the reviews so far have been related to unit tests or minor
formal corrections.</font><font size=2 face="sans-serif">"</font>
<br>
<br><font size=2 face="sans-serif">As was pointed out by me in patch set
1 here: </font><a href=https://review.openstack.org/#/c/43592/><font size=3 color=blue><u>https://review.openstack.org/#/c/43592/</u></font></a><font size=3>
</font>
<br>
<br><font size=2 face="sans-serif">There was no unit test coverage for
an entire module (nova.virt.hyperv.volumeops) before that patch.</font>
<br>
<br><font size=2 face="sans-serif">So while I agree that driver maintainers
know their code the best and how it all works with the dirty details, but
they are also going to be the ones to cut corners to get things fixed which
usually shows up in a lack of test coverage - and that's a good reason
to have external reviewers on everything, to keep us all honest.<br>
</font>
<br><font size=2 face="sans-serif"><br>
</font>
<br><font size=1 face="Arial">Thanks,</font>
<br>
<br><font size=3 color=#8f8f8f face="Arial"><b>MATT RIEDEMANN</b></font><font size=1 face="Arial"><br>
Advisory Software Engineer<br>
Cloud Solutions and OpenStack Development</font>
<table width=680 style="border-collapse:collapse;">
<tr height=8>
<td width=680 colspan=2 style="border-style:solid;border-color:#000000;border-width:0px 0px 0px 0px;padding:0px 0px;">
<hr>
<tr valign=top height=8>
<td width=418 style="border-style:solid;border-color:#000000;border-width:0px 0px 0px 0px;padding:0px 0px;"><font size=1 color=#4181c0 face="Arial"><b>Phone:</b></font><font size=1 color=#5f5f5f face="Arial">
1-507-253-7622</font><font size=1 color=#4181c0 face="Arial"> | <b>Mobile:</b></font><font size=1 color=#5f5f5f face="Arial">
1-507-990-1889</font><font size=1 color=#4181c0 face="Arial"><b><br>
E-mail:</b></font><font size=1 color=#5f5f5f face="Arial"> </font><a href=mailto:mriedem@us.ibm.com target=_blank><font size=1 color=#5f5f5f face="Arial"><u>mriedem@us.ibm.com</u></font></a>
<td width=261 style="border-style:solid;border-color:#000000;border-width:0px 0px 0px 0px;padding:0px 0px;">
<div align=right><img src=cid:_1_09B25FAC09B25A180057DFB386257C05 width=83 height=30 alt=IBM><font size=1 color=#5f5f5f face="Arial"><br>
<br>
3605 Hwy 52 N<br>
Rochester, MN 55901-1407<br>
United States</font></div></table>
<br>
<br>
<br>
<br>
<br><font size=1 color=#5f5f5f face="sans-serif">From:
</font><font size=1 face="sans-serif">Alessandro Pilotti
<apilotti@cloudbasesolutions.com></font>
<br><font size=1 color=#5f5f5f face="sans-serif">To:
</font><font size=1 face="sans-serif">OpenStack Development
Mailing List <openstack-dev@lists.openstack.org>, </font>
<br><font size=1 color=#5f5f5f face="sans-serif">Date:
</font><font size=1 face="sans-serif">10/15/2013 10:39 AM</font>
<br><font size=1 color=#5f5f5f face="sans-serif">Subject:
</font><font size=1 face="sans-serif">Re: [openstack-dev]
[Hyper-V] Havana status</font>
<br>
<hr noshade>
<br>
<br>
<br>
<br><font size=3>On Oct 15, 2013, at 18:14 , Duncan Thomas <</font><a href=mailto:duncan.thomas@gmail.com><font size=3 color=blue><u>duncan.thomas@gmail.com</u></font></a><font size=3>>
wrote:</font>
<br>
<br><font size=3>On 11 October 2013 15:41, Alessandro Pilotti<br>
<</font><a href=mailto:apilotti@cloudbasesolutions.com><font size=3 color=blue><u>apilotti@cloudbasesolutions.com</u></font></a><font size=3>>
wrote:</font>
<br><font size=3>Current reviews require:<br>
<br>
+1 "de facto" driver X mantainer(s)<br>
+2 core reviewer<br>
+2A core reviewer<br>
<br>
While with the proposed scenario we'd get to a way faster route:<br>
<br>
+2 driver X mantainer<br>
+2A another driver X mantainer or a core reviewer<br>
<br>
This would make a big difference in terms of review time.</font>
<br><font size=3><br>
Unfortunately I suspect it would also lead to a big difference in<br>
review quality, and not in a positive way. The things that are<br>
important / obvious to somebody who focuses on one driver are totally<br>
different, and often far more limited, than the concerns of somebody<br>
who reviews many drivers and core code changes.</font>
<br>
<br><font size=3>Although the eyes of somebody which comes from a different
domain bring usually additional points of views and befits, this was not
particularly the case for what our driver is concerned. As I already wrote,
almost all the reviews so far have been related to unit tests or minor
formal corrections. </font>
<br>
<br><font size=3>I disagree on the "far more limited": driver
devs (at least in our case), have to work on a wider range of projects
beside Nova (e.g.: Neutron, Cinder, Ceilometer and outside proper OpenStack
OpenVSwitch and Crowbar, to name the most relevant cases). </font>
<br>
<br>
<br>
<br>
<br><font size=3><br>
-- <br>
Duncan Thomas<br>
<br>
_______________________________________________<br>
OpenStack-dev mailing list</font><font size=3 color=blue><u><br>
</u></font><a href="mailto:OpenStack-dev@lists.openstack.org"><font size=3 color=blue><u>OpenStack-dev@lists.openstack.org</u></font></a><font size=3><br>
</font><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev"><font size=3>http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</font></a>
<br><tt><font size=2>_______________________________________________<br>
OpenStack-dev mailing list<br>
OpenStack-dev@lists.openstack.org<br>
</font></tt><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev"><tt><font size=2>http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</font></tt></a><tt><font size=2><br>
</font></tt>
<br>