<div dir="ltr">Really a good idea! It's painful for us to summit a patch, then waiting for reviewing because of the time difference. It's more painful if we get a -1 after getting up. It's very appreciated that if someone could help, and we can help others, too.</div>
<div class="gmail_extra"><br><br><div class="gmail_quote">2013/10/12 Nikhil Manchanda <span dir="ltr"><<a href="mailto:nikhil@manchanda.me" target="_blank">nikhil@manchanda.me</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div dir="ltr">Just wanted to chime in that Trove also follows this approach and it's worked pretty well for us.<div>+1 on Doug's suggestion to leave a comment on the patch so that two reviewers don't end up doing the same work fixing it.</div>
<div><br></div><div>Cheers,</div><div>-Nikhil</div><div><br></div></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><br><div class="gmail_quote">On Fri, Oct 11, 2013 at 12:17 PM, Dolph Mathews <span dir="ltr"><<a href="mailto:dolph.mathews@gmail.com" target="_blank">dolph.mathews@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote"><div>On Fri, Oct 11, 2013 at 1:34 PM, Clint Byrum <span dir="ltr"><<a href="mailto:clint@fewbar.com" target="_blank">clint@fewbar.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Recently in the TripleO meeting we identified situations where we need<br>
to make it very clear that it is ok to pick up somebody else's patch<br>
and finish it. We are broadly distributed, time-zone-wise, and I know<br>
other teams working on OpenStack projects have the same situation. So<br>
when one of us starts the day and sees an obvious issue with a patch,<br>
we have decided to take action, rather than always -1 and move on. We<br>
clarified for our core reviewers that this does not mean that now both<br>
of you cannot +2. We just need at least one person who hasn't been in<br>
the code to also +2 for an approval*.<br>
<br>
I think all projects can benefit from this model, as it will raise<br>
velocity. It is not perfect for everything, but it is really great when<br>
running up against deadlines or when a patch has a lot of churn and thus<br>
may take a long time to get through the "rebase gauntlet".<br>
<br>
So, all of that said, I want to encourage all OpenStack developers to<br>
say "thanks for fixing my patch" when somebody else does so. It may seem<br>
obvious, but publicly expressing gratitude will make it clear that you<br>
do not take things personally and that we're all working together.<br>
<br>
Thanks for your time -Clint<br>
<br>
* If all core reviewers have been in on the patch, then any two +2's<br>
work.<br>
<br></blockquote><div><br></div></div><div>+1 across the board -- keystone-core follows this approach, especially around feature freeze / release candidate time.</div><div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div></div><span><font color="#888888"><br><br clear="all"><div><br></div>-- <br><div><br></div>-Dolph
</font></span></div></div>
<br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>
</div></div><br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr"><div><b><font color="#000000" style="background-color:rgb(243,243,243)">--------------------------------------------</font></b></div><div><font color="#0000ff"><b>Lingxian Kong</b></font></div>
<div><font color="#ff00ff">Huawei Technologies Co.,LTD.</font></div><div><font color="#ff00ff">IT Product Line CloudOS PDU</font></div><div><font color="#ff00ff">China, Xi'an</font></div><div><font color="#ff00ff">Mobile: +86-18602962792</font></div>
<div><font color="#ff00ff">Email: <a href="mailto:konglingxian@huawei.com" target="_blank">konglingxian@huawei.com</a>; <a href="mailto:anlin.kong@gmail.com" target="_blank">anlin.kong@gmail.com</a></font></div></div>
</div>