<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">
<div apple-content-edited="true"><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; ">
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; ">
<div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">
<br>
</div>
</span></div>
</span></span></div>
<br>
<div>
<div>On Oct 11, 2013, at 17:17 , Russell Bryant <<a href="mailto:rbryant@redhat.com">rbryant@redhat.com</a>></div>
<div> wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">On 10/11/2013 09:02 AM, Alessandro Pilotti wrote:<br>
<blockquote type="cite">OpenStack is organized differently: there are lots of separate projects (Nova, Neutrom, Glance, etc) instead of a single one (which is a good thing), but I believe that a similar approach can be applied. Specific contributors can be
nominated "core rewievers" on specific directories in the tree only and that would scale immediately the core review bandwidth.
<br>
<br>
As a practical example for Nova: in our case that would simply include the following subtrees: "nova/virt/hyperv" and "nova/tests/virt/hyperv". Other projects didn't hit the review bandwidth limits yet as heavily as Nova did, but the same concept could be applied
everywhere. <br>
</blockquote>
<br>
If maintainers of a particular driver would prefer this sort of<br>
autonomy, I'd rather look at creating new repositories. I'm completely<br>
open to going that route on a per-driver basis. Thoughts?<br>
</blockquote>
<div><br>
</div>
<div>Well, as long as it is an official project this would make definitely sense, at least for Hyper-V.</div>
<div>Stability of the driver's interface has never been a particular issue to prevent this to happen IMO.</div>
<div>We should think about how to handle the testing, considering that we are getting ready with the CI gate.</div>
<div><br>
</div>
<blockquote type="cite">For the main tree, I think we already do something like this in<br>
practice. Core reviewers look for feedback (+1/-1) from experts of that<br>
code and take it heavily into account when doing the review.<br>
<br>
</blockquote>
<div><br>
</div>
<div>There's only one "small" issue with the current approach.</div>
<div><br>
</div>
<div>Current reviews require:</div>
<div><br>
</div>
<div>+1 <span class="Apple-tab-span" style="white-space:pre"></span>"de facto" driver X mantainer(s)</div>
<div>+2<span class="Apple-tab-span" style="white-space:pre"> </span> core reviewer</div>
<div>+2A<span class="Apple-tab-span" style="white-space:pre"> </span> core reviewer</div>
<div><br>
</div>
<div>While with the proposed scenario we'd get to a way faster route:</div>
<div><br>
</div>
<div>
<div>+2 <span class="Apple-tab-span" style="white-space:pre"> </span>driver X mantainer</div>
<div>+2A<span class="Apple-tab-span" style="white-space:pre"> </span>another driver X mantainer or a core reviewer</div>
</div>
<div><br>
</div>
<div>This would make a big difference in terms of review time.</div>
<div><br>
</div>
<div>Thanks,</div>
<div><br>
</div>
<div>Alessandro</div>
<div><br>
</div>
<br>
<blockquote type="cite">-- <br>
Russell Bryant<br>
<br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev<br>
</blockquote>
</div>
<br>
</body>
</html>