<div dir="ltr"><div>Hi,</div><div><br></div>1.We used mvn to create tar.gz and I'll add documentation for that.<div>2. The command is simple: "parameter1='some_value1' ... parameterN='some_valueN' disk-image-create element1 ... elementM -o image_name".</div>
<div>Some files in ~/.cache/image-create/ are owned by root (for example, it is file SHA256SUMS*). So, we need to use 'sudo' for cleaning this directory.</div><div>3. This script should not be run with itself. And the command "disk-image-create" should not be run with itself too.</div>
<div><br></div><div>Thanks, Ivan.</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">2013/9/3 Matthew Farrellee <span dir="ltr"><<a href="mailto:matt@redhat.com" target="_blank">matt@redhat.com</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Long weekend here in the US, so I didn't get a chance to comment before this was merged, so...<br>
<br>
Re Oozie - How did you create the oozie-3.3.2.tar.gz?<br>
<br>
Re sudo image-cache - That's not the case for me, the wget is run without sudo. How are you running disk-image-create?<br>
<br>
Re DIB_work - it's best practice to use /tmp for temporary work, and mktemp. This script running concurrently with itself will result in unknown output.<br>
<br>
Best,<br>
<br>
<br>
matt<br>
<br>
-------- Original Message --------<br>
Subject: Change in stackforge/savanna-extra[<u></u>master]: Add diskimage-creating script, elements for mirrors<br>
Date: Thu, 29 Aug 2013 14:37:36 +0000<br>
From: Ivan Berezovskiy (Code Review) <<a href="mailto:review@openstack.org" target="_blank">review@openstack.org</a>><br>
Reply-To: <a href="mailto:iberezovskiy@mirantis.com" target="_blank">iberezovskiy@mirantis.com</a><br>
CC: Sergey Lukjanov <<a href="mailto:slukjanov@mirantis.com" target="_blank">slukjanov@mirantis.com</a>>, Dmitry Mescheryakov <<a href="mailto:dmescheryakov@mirantis.com" target="_blank">dmescheryakov@mirantis.com</a>>, Nadya Privalova <<a href="mailto:nprivalova@mirantis.com" target="_blank">nprivalova@mirantis.com</a>>, Matthew Farrellee <<a href="mailto:matt@redhat.com" target="_blank">matt@redhat.com</a>><br>
<br>
Ivan Berezovskiy has posted comments on this change.<div class="im"><br>
<br>
Change subject: Add diskimage-creating script, elements for mirrors<br>
..............................<u></u>..............................<u></u>..........<br>
<br>
<br></div>
Patch Set 6: (16 inline comments)<div class="im"><br>
<br>
..............................<u></u>......................<br>
File diskimage-create/diskimage-<u></u>create.sh<br>
Line 11: export OOZIE_DOWNLOAD_URL="<a href="http://a8e0dce84b3f00ed7910-a5806ff0396addabb148d230fde09b7b.r31.cf1.rackcdn.com/oozie-3.3.2.tar.gz" target="_blank">http://<u></u>a8e0dce84b3f00ed7910-<u></u>a5806ff0396addabb148d230fde09b<u></u>7b.r31.cf1.rackcdn.com/oozie-<u></u>3.3.2.tar.gz</a>"<br>
</div>
We don't use custom tarball. It is our own tarbal. Please, show me link, if you know, where I can download oozie with all binary files.<div class="im"><br>
<br>
Line 15: if [ $str = 'NAME="Ubuntu"' ]; then<br></div>
Package 'redhat-lsb' is not preinstalled in some Fedora images like cloud image. So, we can't use this command.<br>
In DIB you can see script 02-lsb ('<a href="https://github.com/openstack/diskimage-builder/blob/master/elements/fedora/pre-install.d/02-lsb" target="_blank">https://github.com/<u></u>openstack/diskimage-builder/<u></u>blob/master/elements/fedora/<u></u>pre-install.d/02-lsb</a>') that install this package.<br>
<br>
Line 21: fi<br>
Done<div class="im"><br>
<br>
Line 24: sudo rm -rf /home/$USER/.cache/image-<u></u>create/*<br></div>
Image caching execute under 'sudo'. You can try to delete images without sudo and you'll see 'premission denied'<br>
<br>
Line 31: cd DIB_work<br>
Why? This directory will be removed after creating images.<div class="im"><br>
<br>
Line 41: export DIB_COMMIT_ID=`git show --format=%H | head -1`<br>
</div><a href="https://github.com/stackforge/savanna-extra/blob/master/elements/savanna-version/install.d/01-savanna-version" target="_blank">https://github.com/stackforge/<u></u>savanna-extra/blob/master/<u></u>elements/savanna-version/<u></u>install.d/01-savanna-version</a><br>
<br>
Line 42: cd ../<br>
Done<div class="im"><br>
<br>
Line 48: export SAVANNA_ELEMENTS_COMMIT_ID=`<u></u>git show --format=%H | head -1`<br>
</div><a href="https://github.com/stackforge/savanna-extra/blob/master/elements/savanna-version/install.d/01-savanna-version" target="_blank">https://github.com/stackforge/<u></u>savanna-extra/blob/master/<u></u>elements/savanna-version/<u></u>install.d/01-savanna-version</a><br>
<br>
Line 49: cd ../<br>
Done<br>
<br>
Line 64: fi<br>
We can't use 'lsb_release' as I said before.<div class="im"><br>
<br>
..............................<u></u>......................<br>
File diskimage-create/README.rst<br>
Line 7: 1. If you want to change build parameters, you should edit this script at 'export' commands.<br></div>
Done<div class="im"><br>
<br>
Line 9: 2. If you want to use your local mirrors, you can specify urls for Fedora and Ubuntu mirrors using parameters 'FEDORA_MIRROR' and 'UBUNTU_MIRROR' like this:<br></div>
Done<div class="im"><br>
<br>
Line 15: 3. If you want to add your element to this repository, you should edit this script in your commit (you should export variables for your element and add name of element to variables 'element_sequence').<br>
</div>
Done<div class="im"><br>
<br>
..............................<u></u>......................<br>
File elements/apt-mirror/root.d/0-<u></u>check<br>
Line 2: if [ -z "$UBUNTU_MIRROR" ]; then<br></div>
Done<div class="im"><br>
<br>
..............................<u></u>......................<br>
File elements/yum-mirror/root.d/0-<u></u>check<br>
Line 2: if [ -z "$FEDORA_MIRROR" ]; then<br></div>
Done<div class="im"><br>
<br>
..............................<u></u>......................<br>
File README.rst<br>
Line 10: * Script for creating Fedora and Ubuntu cloud images with our elements and default parameters. You should run command only:<br></div>
Done<div class="im"><br>
<br>
--<br>
To view, visit <a href="https://review.openstack.org/43916" target="_blank">https://review.openstack.org/<u></u>43916</a><br>
To unsubscribe, visit <a href="https://review.openstack.org/settings" target="_blank">https://review.openstack.org/<u></u>settings</a><br>
<br>
Gerrit-MessageType: comment<br>
Gerrit-Change-Id: I12632b5cee42b1dbfd79b7b7c3a7b<u></u>26962ace625<br>
Gerrit-PatchSet: 6<br>
Gerrit-Project: stackforge/savanna-extra<br>
Gerrit-Branch: master<br>
Gerrit-Owner: Ivan Berezovskiy <<a href="mailto:iberezovskiy@mirantis.com" target="_blank">iberezovskiy@mirantis.com</a>><br>
Gerrit-Reviewer: Dmitry Mescheryakov <<a href="mailto:dmescheryakov@mirantis.com" target="_blank">dmescheryakov@mirantis.com</a>><br>
Gerrit-Reviewer: Ivan Berezovskiy <<a href="mailto:iberezovskiy@mirantis.com" target="_blank">iberezovskiy@mirantis.com</a>><br>
Gerrit-Reviewer: Jenkins<br>
Gerrit-Reviewer: Matthew Farrellee <<a href="mailto:matt@redhat.com" target="_blank">matt@redhat.com</a>><br>
Gerrit-Reviewer: Nadya Privalova <<a href="mailto:nprivalova@mirantis.com" target="_blank">nprivalova@mirantis.com</a>><br></div>
Gerrit-Reviewer: Sergey Lukjanov <<a href="mailto:slukjanov@mirantis.com" target="_blank">slukjanov@mirantis.com</a>><br>
<br>
<br>
<br>
______________________________<u></u>_________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.<u></u>org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev</a><br>
</blockquote></div><br></div>