<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 12 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.hoenzb
{mso-style-name:hoenzb;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="ZH-CN" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D">Definitely, +1 ;-)<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D">--<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D">Shane</span><span lang="EN" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span lang="EN-US" style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Joe Gordon [mailto:joe.gordon0@gmail.com]
<br>
<b>Sent:</b> Tuesday, August 27, 2013 11:40 PM<br>
<b>To:</b> Daniel P. Berrange; OpenStack Development Mailing List<br>
<b>Subject:</b> Re: [openstack-dev] [Nova] Frustrations with review wait times<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span lang="EN-US"><o:p> </o:p></span></p>
<div>
<p class="MsoNormal"><span lang="EN-US">On Tue, Aug 27, 2013 at 11:04 AM, Daniel P. Berrange <<a href="mailto:berrange@redhat.com" target="_blank">berrange@redhat.com</a>> wrote:<o:p></o:p></span></p>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt"><span lang="EN-US">On Tue, Aug 27, 2013 at 10:55:03AM -0400, Russell Bryant wrote:<br>
> On 08/27/2013 10:43 AM, Daniel P. Berrange wrote:<br>
> > I tend to focus the bulk of my review activity on the libvirt driver,<br>
> > since that's where most of my knowledge is. I've recently done some<br>
> > reviews outside this area to help reduce our backlog, but I'm not<br>
> > so comfortable approving stuff in many of the general infrastructure<br>
> > shared areas since I've not done much work on those areas of code.<br>
> ><br>
> > I think Nova is large enough that it (mostly) beyond the scope of any<br>
> > one person to know all areas of Nova code well enough todo quality<br>
> > reviews. IOW, as we grow the nova-core team further, it may be worth<br>
> > adding more reviewers who have strong knowledge of specific areas &<br>
> > can focus their review energy in those areas, even if their review<br>
> > count will be low when put in the context of nova as a whole.<br>
><br>
> I'm certainly open to that.<br>
><br>
> Another way I try to do this unofficially is give certain +1s a whole<br>
> lot of weight when I'm looking at a patch. I do this regularly when<br>
> looking over patches to hypervisor drivers I'm not very familiar with.<br>
><br>
> Another thing we could consider is take this approach more officially.<br>
> Oslo has started doing this for its incubator. A maintainer of a part<br>
> of the code not on oslo-core has their +1 treated as a +2 on that code.<br>
><br>
> <a href="http://git.openstack.org/cgit/openstack/oslo-incubator/tree/MAINTAINERS" target="_blank">
http://git.openstack.org/cgit/openstack/oslo-incubator/tree/MAINTAINERS</a><o:p></o:p></span></p>
</div>
<p class="MsoNormal"><span lang="EN-US">Yes, just having a list of expert maintainers for each area of Nova<br>
would certainly be helpful in identifying whose comments to place<br>
more weight by, regardless of anything else we might do.<o:p></o:p></span></p>
<div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">I think we can dynamically generate this based on git log/blame and gerrit statistics per file. For example if someone has authored half the lines in a file or reviewed most of the patches that touched that file, they
are probably are very familiar with the file and would be a good person to review any change.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US"> <o:p></o:p></span></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal"><span lang="EN-US" style="color:#888888"><br>
<span class="hoenzb">Daniel</span><br>
<span class="hoenzb">--</span><br>
<span class="hoenzb">|: <a href="http://berrange.com" target="_blank">http://berrange.com</a> -o- <a href="http://www.flickr.com/photos/dberrange/" target="_blank">http://www.flickr.com/photos/dberrange/</a> :|</span><br>
<span class="hoenzb">|: <a href="http://libvirt.org" target="_blank">http://libvirt.org</a> -o-
<a href="http://virt-manager.org" target="_blank">http://virt-manager.org</a> :|</span><br>
<span class="hoenzb">|: <a href="http://autobuild.org" target="_blank">http://autobuild.org</a> -o-
<a href="http://search.cpan.org/~danberr/" target="_blank">http://search.cpan.org/~danberr/</a> :|</span><br>
<span class="hoenzb">|: <a href="http://entangle-photo.org" target="_blank">http://entangle-photo.org</a> -o-
<a href="http://live.gnome.org/gtk-vnc" target="_blank">http://live.gnome.org/gtk-vnc</a> :|</span></span><span lang="EN-US"><o:p></o:p></span></p>
<div>
<div>
<p class="MsoNormal"><span lang="EN-US"><br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><o:p></o:p></span></p>
</div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
</div>
</div>
</div>
</body>
</html>