<font size=2 face="sans-serif">Going back to the original discussion,
something I've noticed recently is the large patches coming through tied
to blueprints. In at least a few cases I've made comments in patches
asking them to be broken up to be more easily digested. The wiki
also covers that area:</font>
<br>
<br><a href=https://wiki.openstack.org/wiki/GitCommitMessages#Things_to_avoid_when_creating_commits><font size=3 color=blue><u>https://wiki.openstack.org/wiki/GitCommitMessages#Things_to_avoid_when_creating_commits</u></font></a><font size=3>
</font>
<br>
<br><font size=2 face="sans-serif">Discussing this point in IRC today,
I raised one of my primary issues with reviewing large patches (typically
for a blueprint) is how much harder it makes to verify the code is adequately
covered with unit tests.</font>
<br>
<br><font size=2 face="sans-serif">One thought is it'd be cool if we could
get code coverage reports tied to the patches so we know if a given patch
is severely lacking in test coverage (when it's not obvious).</font>
<br>
<br><font size=2 face="sans-serif">This was pointed out:</font>
<br>
<br><a href="http://logs.openstack.org/5c/5cc63c91d045f7a37136107053f71db1d8edf425/post/nova-coverage/e91683d/cover/"><font size=3 color=blue><u>http://logs.openstack.org/5c/5cc63c91d045f7a37136107053f71db1d8edf425/post/nova-coverage/e91683d/cover/</u></font></a><font size=3>
</font>
<br>
<br><font size=2 face="sans-serif">Which is nice and it gives the commit,
but when I asked around in #openstack-infra about it, apparently that's
only in post-queue on merged commits, so doesn't help you with a review.
The infra guys said they'd toyed with doing coverage reports in the
check queue but it took too long (instrumenting the code for coverage added
too much time to the check).</font>
<br>
<br><font size=2 face="sans-serif">However, with the recent push for running
parallel tests with testr, it sounds like it might be worth looking at
check queue coverage reports again which might be a good tool in improving
review efficiency. This is probably something to pursue again after
h3.<br>
</font>
<br><font size=2 face="sans-serif"><br>
</font>
<br><font size=1 face="Arial">Thanks,</font>
<br>
<br><font size=3 color=#8f8f8f face="Arial"><b>MATT RIEDEMANN</b></font><font size=1 face="Arial"><br>
Advisory Software Engineer<br>
Cloud Solutions and OpenStack Development</font>
<table width=680 style="border-collapse:collapse;">
<tr height=8>
<td width=680 colspan=2 style="border-style:solid;border-color:#000000;border-width:0px 0px 0px 0px;padding:0px 0px;">
<hr>
<tr valign=top height=8>
<td width=418 style="border-style:solid;border-color:#000000;border-width:0px 0px 0px 0px;padding:0px 0px;"><font size=1 color=#4181c0 face="Arial"><b>Phone:</b></font><font size=1 color=#5f5f5f face="Arial">
1-507-253-7622</font><font size=1 color=#4181c0 face="Arial"> | <b>Mobile:</b></font><font size=1 color=#5f5f5f face="Arial">
1-507-990-1889</font><font size=1 color=#4181c0 face="Arial"><b><br>
E-mail:</b></font><font size=1 color=#5f5f5f face="Arial"> </font><a href=mailto:mriedem@us.ibm.com target=_blank><font size=1 color=#5f5f5f face="Arial"><u>mriedem@us.ibm.com</u></font></a>
<td width=261 style="border-style:solid;border-color:#000000;border-width:0px 0px 0px 0px;padding:0px 0px;">
<div align=right><img src=cid:_1_0D8F24580D8F1EF00065A62386257BD4 width=83 height=30 alt=IBM><font size=1 color=#5f5f5f face="Arial"><br>
<br>
3605 Hwy 52 N<br>
Rochester, MN 55901-1407<br>
United States</font></div></table>
<br>
<br>
<br>
<br>
<br><font size=1 color=#5f5f5f face="sans-serif">From:
</font><font size=1 face="sans-serif">Russell Bryant <rbryant@redhat.com></font>
<br><font size=1 color=#5f5f5f face="sans-serif">To:
</font><font size=1 face="sans-serif">openstack-dev@lists.openstack.org,
</font>
<br><font size=1 color=#5f5f5f face="sans-serif">Date:
</font><font size=1 face="sans-serif">08/27/2013 01:19 PM</font>
<br><font size=1 color=#5f5f5f face="sans-serif">Subject:
</font><font size=1 face="sans-serif">Re: [openstack-dev]
[Nova] Frustrations with review wait times</font>
<br>
<hr noshade>
<br>
<br>
<br><tt><font size=2>On 08/27/2013 01:30 PM, Matt Dietz wrote:<br>
> Good idea!<br>
> <br>
> Only thing I would point out is there are a fair amount of changes,<br>
> especially lately, where code is just moving from one portion of the<br>
> project to another, so there may be cases where someone ends up being<br>
> authoritative over code they don't totally understand. <br>
<br>
Right. While some automation can provide some insight, it certainly
can<br>
not make any decisions in this area, IMO.<br>
<br>
-- <br>
Russell Bryant<br>
<br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
OpenStack-dev@lists.openstack.org<br>
</font></tt><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev"><tt><font size=2>http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</font></tt></a><tt><font size=2><br>
<br>
</font></tt>
<br>