<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Tue, Aug 27, 2013 at 11:04 AM, Daniel P. Berrange <span dir="ltr"><<a href="mailto:berrange@redhat.com" target="_blank">berrange@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On Tue, Aug 27, 2013 at 10:55:03AM -0400, Russell Bryant wrote:<br>
> On 08/27/2013 10:43 AM, Daniel P. Berrange wrote:<br>
> > I tend to focus the bulk of my review activity on the libvirt driver,<br>
> > since that's where most of my knowledge is. I've recently done some<br>
> > reviews outside this area to help reduce our backlog, but I'm not<br>
> > so comfortable approving stuff in many of the general infrastructure<br>
> > shared areas since I've not done much work on those areas of code.<br>
> ><br>
> > I think Nova is large enough that it (mostly) beyond the scope of any<br>
> > one person to know all areas of Nova code well enough todo quality<br>
> > reviews. IOW, as we grow the nova-core team further, it may be worth<br>
> > adding more reviewers who have strong knowledge of specific areas &<br>
> > can focus their review energy in those areas, even if their review<br>
> > count will be low when put in the context of nova as a whole.<br>
><br>
> I'm certainly open to that.<br>
><br>
> Another way I try to do this unofficially is give certain +1s a whole<br>
> lot of weight when I'm looking at a patch. I do this regularly when<br>
> looking over patches to hypervisor drivers I'm not very familiar with.<br>
><br>
> Another thing we could consider is take this approach more officially.<br>
> Oslo has started doing this for its incubator. A maintainer of a part<br>
> of the code not on oslo-core has their +1 treated as a +2 on that code.<br>
><br>
> <a href="http://git.openstack.org/cgit/openstack/oslo-incubator/tree/MAINTAINERS" target="_blank">http://git.openstack.org/cgit/openstack/oslo-incubator/tree/MAINTAINERS</a><br>
<br>
</div>Yes, just having a list of expert maintainers for each area of Nova<br>
would certainly be helpful in identifying whose comments to place<br>
more weight by, regardless of anything else we might do.<br></blockquote><div><br></div><div>I think we can dynamically generate this based on git log/blame and gerrit statistics per file. For example if someone has authored half the lines in a file or reviewed most of the patches that touched that file, they are probably are very familiar with the file and would be a good person to review any change.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888"><br>
Daniel<br>
--<br>
|: <a href="http://berrange.com" target="_blank">http://berrange.com</a> -o- <a href="http://www.flickr.com/photos/dberrange/" target="_blank">http://www.flickr.com/photos/dberrange/</a> :|<br>
|: <a href="http://libvirt.org" target="_blank">http://libvirt.org</a> -o- <a href="http://virt-manager.org" target="_blank">http://virt-manager.org</a> :|<br>
|: <a href="http://autobuild.org" target="_blank">http://autobuild.org</a> -o- <a href="http://search.cpan.org/~danberr/" target="_blank">http://search.cpan.org/~danberr/</a> :|<br>
|: <a href="http://entangle-photo.org" target="_blank">http://entangle-photo.org</a> -o- <a href="http://live.gnome.org/gtk-vnc" target="_blank">http://live.gnome.org/gtk-vnc</a> :|<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br></div></div>