<div dir="ltr"><br><div class="gmail_extra"><div class="gmail_quote">On Thu, Aug 15, 2013 at 7:57 AM, Christopher Yeoh <span dir="ltr"><<a href="mailto:cbkyeoh@gmail.com" target="_blank">cbkyeoh@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Aug 15, 2013 at 9:54 PM, Daniel P. Berrange <span dir="ltr"><<a href="mailto:berrange@redhat.com" target="_blank">berrange@redhat.com</a>></span> wrote:Commit message quality has improved somewhat since I first wrote & published<div class="im">
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
that page, but there's definitely still scope to improve things further. What<br>
it really needs is for more reviewers to push back against badly written<br>
commit messages, to nudge authors into the habit of being more verbose in<br>
their commits.<br>
<br></blockquote><div><br></div></div><div>Agreed. There is often "what" and sometimes "why", but not very often<br>"how" in commit messages.<br></div></div></div></div></blockquote><div><br>
</div><div>++</div><div><br></div><div>Beyond the one line summary (which *should* describe "what" changed), describing "what" changed in the commit message is entirely redundant with the commit itself.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><div> Chris<br></div></div>
</div></div>
<br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div><br></div>-Dolph
</div></div>