<div dir="ltr"><div>On Thu, Aug 8, 2013 at 12:41 PM, Joshua Harlow <span dir="ltr"><<a href="mailto:harlowja@yahoo-inc.com" target="_blank">harlowja@yahoo-inc.com</a>></span> wrote:<br></div><div class="gmail_extra">
<div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div style="font-size:14px;font-family:Calibri,sans-serif;word-wrap:break-word">
<div>Agreed. I'd at least like to have the bug referenced have at least more context.</div>
<div><br>
</div>
<div>The commit message links to the bug, so that’s a plus (but not ideal).</div></div></blockquote><div><br></div><div><ul style="padding:0px;margin:0.3em 0px 0px 1.6em;color:rgb(51,51,51);font-family:'Arial Unicode MS',Arial,sans-serif;font-size:14px;line-height:20px">
<li><b>Do not assume the reviewer has access to external web services/site.</b></li></ul><p style="margin:0px 0px 10px;color:rgb(51,51,51);font-family:'Arial Unicode MS',Arial,sans-serif;font-size:14px;line-height:20px">
In 6 months time when someone is on a train/plane/coach/beach/pub troubleshooting a problem & browsing GIT history, there is no guarantee they will have access to the online bug tracker, or online blueprint documents. The great step forward with distributed SCM is that you no longer need to be "online" to have access to all information about the code repository. The commit message should be totally self-contained, to maintain that benefit.</p>
<ul style="padding:0px;margin:0.3em 0px 0px 1.6em;color:rgb(51,51,51);font-family:'Arial Unicode MS',Arial,sans-serif;font-size:14px;line-height:20px"></ul></div><div><a href="https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages">https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages</a><br>
</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div style="font-size:14px;font-family:Calibri,sans-serif;word-wrap:break-word">
<div><br>
</div>
<span>
<div style="border-width:1pt medium medium;border-style:solid none none;padding:3pt 0in 0in;text-align:left;font-size:11pt;font-family:Calibri;border-top-color:rgb(181,196,223)">
<span style="font-weight:bold">From: </span>Joe Gordon <<a href="mailto:joe.gordon0@gmail.com" target="_blank">joe.gordon0@gmail.com</a>><br>
<span style="font-weight:bold">Reply-To: </span>OpenStack Development Mailing List <<a href="mailto:openstack-dev@lists.openstack.org" target="_blank">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Date: </span>Thursday, August 8, 2013 12:14 PM<br>
<span style="font-weight:bold">To: </span>OpenStack Development Mailing List <<a href="mailto:openstack-dev@lists.openstack.org" target="_blank">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Subject: </span>Re: [openstack-dev] Oslo.exception being dropped??<br>
</div><div><div class="h5">
<div><br>
</div>
<div>
<div>
<div dir="ltr">This touches on one of my big pet peeves, in the commit message one should:
<div><br>
</div>
<div>"<b style="color:rgb(51,51,51);font-family:'Arial Unicode MS',Arial,sans-serif;font-size:14px;line-height:20px">Describe <i>why</i> a change is being made.</b></div>
<p style="margin:0px 0px 10px;color:rgb(51,51,51);font-family:'Arial Unicode MS',Arial,sans-serif;font-size:14px;line-height:20px">
A common mistake is to just document how the code has been written, without describing /why/ the developer chose to do it that way. By all means describe the overall code structure, particularly for large changes, but more importantly describe the intent/motivation
behind the changes."</p>
<p style="margin:0px 0px 10px;color:rgb(51,51,51);font-family:'Arial Unicode MS',Arial,sans-serif;font-size:14px;line-height:20px">
Actually, <a href="https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages" target="_blank">https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages</a> has a really great description of what a commit message should include
and why, but rarely due.</p>
</div>
<div class="gmail_extra"><br>
<br>
<div class="gmail_quote">On Thu, Aug 8, 2013 at 12:03 PM, Mac Innes, Kiall <span dir="ltr">
<<a href="mailto:kiall@hp.com" target="_blank">kiall@hp.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Taking a total guess here... But, I reckon that it's usefulness now that<br>
oslo.* are being spun off into "real projects" means that the shared<br>
dependency is becoming a problem.<br>
<br>
e.g. oslo.config and oslo.messaging shouldn't both include it, so should<br>
a whole oslo.exception library be created for what is essentially 1<br>
shared base exception class? I personally don't think so.<br>
<br>
Thanks,<br>
Kiall<br>
<div>
<div><br>
On 08/08/13 19:12, Joshua Harlow wrote:<br>
> Hi recently I was working with some cinder code and noticed that<br>
> oslo.exception is being dropped from it (and other projects).<br>
><br>
> It seems connected back to this bug:<br>
> <a href="https://bugs.launchpad.net/oslo/+bug/1208734" target="_blank">https://bugs.launchpad.net/oslo/+bug/1208734</a><br>
><br>
> <a href="https://github.com/openstack/oslo-incubator/blob/master/MAINTAINERS#L118" target="_blank">
https://github.com/openstack/oslo-incubator/blob/master/MAINTAINERS#L118</a><br>
><br>
> I'm just wondering if there is any more reason for why it is obsoleted,<br>
> is it being replaced? Was there just no one supporting it? Was it<br>
> decided that its not useful?<br>
><br>
> Thanks much,<br>
><br>
> Josh<br>
<br>
</div>
</div>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</div></div></span>
</div>
</blockquote></div><br></div></div>