<div dir="ltr">Roman,<div><br></div><div>Basically, that is explained in Gerrit built-in documentation, for example: </div><div><br></div><div><a href="https://review.openstack.org/Documentation/user-changeid.html">https://review.openstack.org/Documentation/user-changeid.html</a></div>
<div><br></div><div>I guess, the Wiki pages assumes that reader has some grade of experience with Gerrit, and require more context to be added to them.</div><div><br></div><div>Hope that helps.</div><div><br></div><div>--</div>
<div>Best regards,</div><div>Oleg Gelbukh</div><div>Mirantis Inc</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Aug 7, 2013 at 4:44 PM, Roman Gorodeckij <span dir="ltr"><<a href="mailto:holms@holms.lt" target="_blank">holms@holms.lt</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word"><div>Hi,</div><div><br></div>I just completely messed up in here. <div><br></div><div>
Was reading a manual about Gerrit workflow: <a href="https://wiki.openstack.org/wiki/Gerrit_Workflow#Committing_Changes" target="_blank">https://wiki.openstack.org/wiki/Gerrit_Workflow#Committing_Changes</a></div><div>And then there's link to here about how to build commit messages: <a href="https://wiki.openstack.org/wiki/GitCommitMessages" target="_blank">https://wiki.openstack.org/wiki/GitCommitMessages</a><div>
<br></div><div>and I'm starting to see "Change-id" line in every commit message, which naturally makes me wonder, what is this at all..?</div><div><br></div><div>There's explanation in manual </div><div>
<br></div><ul style="line-height:20px;color:rgb(51,51,51);margin:0.3em 0px 0px 1.6em;padding:0px"><li>The 'Change-id' line is a unique hash describing the change, which is generated by a GIT commit hook. This should not be changed when rebasing a commit following review feedback, since it is used by Gerrit, to track versions of a patch.</li>
</ul><div><br></div><div>and my first reaction is … 'wat?'. What is git commit hook? Where's instruction how to install it. If manual should explain workflow, I'd like to have full of it, not just "figure out your self"</div>
<div><br></div><div>Of course in IRC #openstack-dev this was explained:</div><div><br></div><div><div>08:26 < agorodnev> holms: usually I push to gerrit and it tells me that I forgot to add change id and</div><div>
suggests me change id =) I copy it, do git commit --amend, append change id to commit</div>
<div> message. That works =)</div></div><div>08:28 < agorodnev> holms: you need to put commit-msg file to .git/hooks</div><div>08:31 < agorodnev> $>scp -p -P 29418 <your-login>@review.openstack.org:hooks/commit-msg .git/hooks/</div>
<div><br></div><div>1) I'm considering this practise not normal at all, just a workaround</div><div>2) Would be nice to have this in manual, because I just don't know what to do next if I'm on my own learning curve. </div>
<div><br></div><div>Cheers,</div><div><br></div><div><br></div><div><div><div><br></div></div></div></div></div><br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>