<html><head><meta http-equiv="Content-Type" content="text/html charset=windows-1252"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>Hi,</div><div><br></div>I just completely messed up in here. <div><br></div><div>Was reading a manual about Gerrit workflow: <a href="https://wiki.openstack.org/wiki/Gerrit_Workflow#Committing_Changes">https://wiki.openstack.org/wiki/Gerrit_Workflow#Committing_Changes</a></div><div>And then there's link to here about how to build commit messages: <a href="https://wiki.openstack.org/wiki/GitCommitMessages">https://wiki.openstack.org/wiki/GitCommitMessages</a><div><br></div><div>and I'm starting to see "Change-id" line in every commit message, which naturally makes me wonder, what is this at all..?</div><div><br></div><div>There's explanation in manual </div><div><br></div><ul style="padding: 0px; margin: 0.3em 0px 0px 1.6em; color: rgb(51, 51, 51); line-height: 20px; background-color: rgb(255, 255, 255); "><li>The 'Change-id' line is a unique hash describing the change, which is generated by a GIT commit hook. This should not be changed when rebasing a commit following review feedback, since it is used by Gerrit, to track versions of a patch.</li></ul><div><br></div><div>and my first reaction is … 'wat?'. What is git commit hook? Where's instruction how to install it. If manual should explain workflow, I'd like to have full of it, not just "figure out your self"</div><div><br></div><div>Of course in IRC #openstack-dev this was explained:</div><div><br></div><div><div>08:26 < agorodnev> holms: usually I push to gerrit and it tells me that I forgot to add change id and</div><div> suggests me change id =) I copy it, do git commit --amend, append change id to commit</div><div> message. That works =)</div></div><div>08:28 < agorodnev> holms: you need to put commit-msg file to .git/hooks</div><div>08:31 < agorodnev> $>scp -p -P 29418 <your-login>@review.openstack.org:hooks/commit-msg .git/hooks/</div><div><br></div><div>1) I'm considering this practise not normal at all, just a workaround</div><div>2) Would be nice to have this in manual, because I just don't know what to do next if I'm on my own learning curve. </div><div><br></div><div>Cheers,</div><div><br></div><div><br></div><div><div><div><br></div></div></div></div></body></html>