<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<div class="moz-cite-prefix">On 07/05/2013 10:57 AM, Dolph Mathews
wrote:<br>
</div>
<blockquote
cite="mid:CAC=h7gUmSZjLDCSDqLWXtfixmRJH4fGo=mugEP-_1cW=GAESkw@mail.gmail.com"
type="cite">
<div dir="ltr"><br>
<div class="gmail_extra">
<div class="gmail_quote">On Mon, Jul 1, 2013 at 3:24 PM, David
Ripton <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:dripton@redhat.com" target="_blank">dripton@redhat.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb">
<div class="h5">On 07/01/2013 12:49 PM, Brant Knudson
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
'Stackers -<br>
<br>
I've got a review up in Keystone that converts
tables from MyISAM to<br>
InnoDB [0], which I patterned after a change in
Nova. One of the<br>
comments in the review is suggesting that the
migrate_version table<br>
should also be changed. The reason I didn't include
migrate_version is<br>
because that's the way Nova did it, but other than
that I don't know why<br>
migrate_version should not be converted. The Nova
code is pretty<br>
explicit that migrate_version isn't changed [1].
Maybe somebody who<br>
knows MySQL or SQLAlchemy-migrate better than I do
can come up with a<br>
reason why migrate_version shouldn't be changed from
MyISAM to InnoDB.<br>
<br>
[0] <a moz-do-not-send="true"
href="https://review.openstack.org/#/c/33102/"
target="_blank">https://review.openstack.org/#/c/33102/</a>
- Use InnoDB for MySQL<br>
[1]<br>
<a moz-do-not-send="true"
href="https://github.com/openstack/nova/blob/master/nova/tests/db/test_migrations.py#L331"
target="_blank">https://github.com/openstack/nova/blob/master/nova/tests/db/test_migrations.py#L331</a><br>
</blockquote>
<br>
</div>
</div>
sqlalchemy-migrate relies on the migrate_versions table,
so modifying it from within a sqlalchemy-migrate script is
scary. And it's a tiny table that's only used during DB
migrations, so I doubt you'd see any actual benefit.</blockquote>
<div><br>
</div>
<div style="">+1; we don't explicitly create the
migrate_versions table in migrations, so we shouldn't be
managing it either. If there's an issue in that table, I'd
say it's most likely on sqlalchemy-migrate or the deployer
to fix, not keystone's migrations.</div>
</div>
</div>
</div>
</blockquote>
<br>
Ah, but we do create that table: That is what is meant by "Database
already managed." It is part of our application, and we are
responsible for it. It is just done as a side effect of us using
the migration code at all.<br>
<br>
<blockquote
cite="mid:CAC=h7gUmSZjLDCSDqLWXtfixmRJH4fGo=mugEP-_1cW=GAESkw@mail.gmail.com"
type="cite">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><span
class="HOEnZb"><font color="#888888"><br>
<br>
-- <br>
David Ripton Red Hat <a moz-do-not-send="true"
href="mailto:dripton@redhat.com" target="_blank">dripton@redhat.com</a><br>
<br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a moz-do-not-send="true"
href="mailto:OpenStack-dev@lists.openstack.org"
target="_blank">OpenStack-dev@lists.openstack.org</a><br>
<a moz-do-not-send="true"
href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev"
target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</font></span></blockquote>
</div>
<br>
<br clear="all">
<div><br>
</div>
-- <br>
<div><br>
</div>
-Dolph
</div>
</div>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
OpenStack-dev mailing list
<a class="moz-txt-link-abbreviated" href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a>
<a class="moz-txt-link-freetext" href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>