<div dir="ltr">Hi Paul,<div><br></div><div style>I'll always cheer when we remove unused code :-)</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, Jun 24, 2013 at 9:58 AM, Paul Bourke <span dir="ltr"><<a href="mailto:pauldbourke@gmail.com" target="_blank">pauldbourke@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I'm adding some unit tests for glance/common/client.py as part of<br>
bug/1115551, and noticed the image_iterator() function<br>
(<a href="https://github.com/openstack/glance/blob/master/glance/common/client.py#L568" target="_blank">https://github.com/openstack/glance/blob/master/glance/common/client.py#L568</a>)<br>
returns two non-existent types, SendFileIterator and<br>
ImageBodyIterator.<br>
<br>
It seems there's no code path that goes down this route; would I be<br>
correct in assuming this is left over from the legacy glanceclient?<br>
<br>
I think there's two possible actions - one would be to remove this and<br>
related code that calls it from do_request.  The other would be to<br>
restore these iterator classes back, so this functionality would still<br>
be supported if desired.  Thoughts?<br>
<br>
Thanks,<br>
-Paul<br>
<br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div><br></div>