<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif; ">
<div>Please keep in mind that not everyone uses tox also ;)</div>
<div><br>
</div>
<div>Some of us use VM's instead of tox+venv and throwaway the VM's when we are done testing whatever change. </div>
<div><br>
</div>
<div>VM's seem more cloudy to me ;)</div>
<div><br>
</div>
<div>I personally like 'run_tests.sh' since its a easy one-stop to running tests, making me not worry about tox/testr/nose syntax (and how the backing test impl seems to change about once a year).</div>
<div><br>
</div>
<div>My 2 cents.</div>
<div><br>
</div>
<span id="OLK_SRC_BODY_SECTION">
<div style="font-family:Calibri; font-size:11pt; text-align:left; color:black; BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<span style="font-weight:bold">From: </span>Joe Gordon <<a href="mailto:joe.gordon0@gmail.com">joe.gordon0@gmail.com</a>><br>
<span style="font-weight:bold">Reply-To: </span>OpenStack Development Mailing List <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Date: </span>Monday, June 17, 2013 4:01 PM<br>
<span style="font-weight:bold">To: </span>OpenStack Development Mailing List <<a href="mailto:openstack-dev@lists.openstack.org">openstack-dev@lists.openstack.org</a>><br>
<span style="font-weight:bold">Subject: </span>[openstack-dev] The future of run_tests.sh<br>
</div>
<div><br>
</div>
<div>
<div>
<div dir="ltr">Hi All,
<div><br>
</div>
<div style="">A patch to move the run_tests.sh script into oslo-incubator (<a href="https://review.openstack.org/#/c/32736/">https://review.openstack.org/#/c/32736/</a>), has brought up the bigger question of what is the future of './run_tests.sh.'</div>
<div style=""><br>
</div>
<div style="">This seems like a topic that directly affects all developers, so it sounded like it should be brought to the Mailing list.</div>
<div style=""><br>
</div>
<div style="">Reasons to keep run_tests.sh:</div>
<div style=""><br>
</div>
<div style="">
<div>* there is no possibility to run tests with testtools instead of testr. This feature allows us to use the debugger.</div>
<div>* in some projects tox doesn't use a testr wrapper to report progress while tests are running </div>
<div style="">* building the sdist can be slow (slow == noticeable)</div>
<div style=""><br>
</div>
<div style=""><br>
</div>
<div style="">Monty's Rant: <br>
<br>
"<span style="color: rgb(0, 0, 0); font-family: 'Arial Unicode MS', Arial, sans-serif; ">So, I'm SUPER torn on this.</span></div>
<p style="margin-top:0px;margin-bottom:0px;padding-top:0.5em;padding-bottom:0.5em;color:rgb(0,0,0);font-family:'Arial Unicode MS',Arial,sans-serif">
On the one hand, we use tox in the gate, and run_tests.sh hides that from people and then they get confused about why some change they made to run_tests.sh doesn't get reflected in the reality of the project.</p>
<p style="margin-top:0px;margin-bottom:0px;padding-top:0.5em;padding-bottom:0.5em;color:rgb(0,0,0);font-family:'Arial Unicode MS',Arial,sans-serif">
On the other hand, what Victor says is true. We need to land a couple of changes to upstream tox that would allow it to not run develop each time - but we seem to have a hard time doing that.</p>
<p style="margin-top:0px;margin-bottom:0px;padding-top:0.5em;padding-bottom:0.5em;color:rgb(0,0,0);font-family:'Arial Unicode MS',Arial,sans-serif">
On the third hand, we'd doing an INSANE amount of work to make working with testing in a venv "easy" and what we've wound up with is a situation where we have multiple competing incompatible ways of doing things.</p>
<p style="margin-top:0px;margin-bottom:0px;padding-top:0.5em;padding-bottom:0.5em;color:rgb(0,0,0);font-family:'Arial Unicode MS',Arial,sans-serif">
Here's what I do: source .tox/py27/bin/activate testr run --parallel testr run --parallel testr run some-test testr run --failing deactivate</p>
<p style="margin-top:0px;margin-bottom:0px;padding-top:0.5em;padding-bottom:0.5em;color:rgb(0,0,0);font-family:'Arial Unicode MS',Arial,sans-serif">
Sometimes, if I'm being fancy, I'll do: virtualenv foo foo/bin/pip install -r requirements.txt -r test-requirements.txt</p>
<p style="margin-top:0px;margin-bottom:0px;padding-top:0.5em;padding-bottom:0.5em;color:rgb(0,0,0);font-family:'Arial Unicode MS',Arial,sans-serif">
I believe vish just installs the depends directly on his box and skips venvs altogether.</p>
<p style="margin-top:0px;margin-bottom:0px;padding-top:0.5em;padding-bottom:0.5em;color:rgb(0,0,0);font-family:'Arial Unicode MS',Arial,sans-serif">
It turns out that testr is a powerful tool with a nice UI. Instead of putting wrappers around it, perhaps we should add support for our output stream thing we like to it upstream. We should also add support to it for dropping into a debugger directly, so that
the testtools issue goes away. Then we should land a patch to upstream tox to get it to do setup.py develop instead of sdist+ install.</p>
<p style="margin-top:0px;margin-bottom:0px;padding-top:0.5em;padding-bottom:0.5em;color:rgb(0,0,0);font-family:'Arial Unicode MS',Arial,sans-serif">
If we did that, we could have "run tox" be the simple answer for anyone who just wants to run whatever the gate runs, because that will always work. And if they want to do fancier things, they should learn about venvs and testr.</p>
<p style="margin-top:0px;margin-bottom:0px;padding-top:0.5em;padding-bottom:0.5em;color:rgb(0,0,0);font-family:'Arial Unicode MS',Arial,sans-serif">
However, if we ARE going to keep a run_tests.sh file in our trees, we should certainly have a single copy and have it behave consistently.</p>
<p style="margin-top:0px;margin-bottom:0px;padding-top:0.5em;padding-bottom:0.5em;color:rgb(0,0,0);font-family:'Arial Unicode MS',Arial,sans-serif">
Please note that some projects actually do just have run_tests.sh as a thin wrapper around tox."</p>
<p style="margin-top:0px;margin-bottom:0px;padding-top:0.5em;padding-bottom:0.5em;color:rgb(0,0,0);font-family:'Arial Unicode MS',Arial,sans-serif">
<br>
</p>
<p style="margin-top:0px;margin-bottom:0px;padding-top:0.5em;padding-bottom:0.5em;color:rgb(0,0,0);font-family:'Arial Unicode MS',Arial,sans-serif">
What do you think? Should we keep run_tests as is and port to oslo, or should we revisit the role of run_tests.sh?</p>
<p style="margin-top:0px;margin-bottom:0px;padding-top:0.5em;padding-bottom:0.5em;color:rgb(0,0,0);font-family:'Arial Unicode MS',Arial,sans-serif">
<br>
</p>
<p style="margin-top:0px;margin-bottom:0px;padding-top:0.5em;padding-bottom:0.5em;color:rgb(0,0,0);font-family:'Arial Unicode MS',Arial,sans-serif">
best,</p>
<p style="margin-top:0px;margin-bottom:0px;padding-top:0.5em;padding-bottom:0.5em;color:rgb(0,0,0);font-family:'Arial Unicode MS',Arial,sans-serif">
Joe</p>
</div>
</div>
</div>
</div>
</span>
</body>
</html>