<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 10, 2013 at 11:20 AM, Sean Dague <span dir="ltr"><<a href="mailto:sean@dague.net" target="_blank">sean@dague.net</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="im">On 06/10/2013 11:26 AM, Dolph Mathews wrote:<br>
</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div class="im">
<br>
On Mon, Jun 10, 2013 at 9:23 AM, Sean Dague <<a href="mailto:sean@dague.net" target="_blank">sean@dague.net</a><br></div><div class="im">
<mailto:<a href="mailto:sean@dague.net" target="_blank">sean@dague.net</a>>> wrote:<br>
<br>
On 06/10/2013 09:48 AM, Alvaro Lopez wrote:<br>
<br>
Hi all.<br>
<br>
I've submitted a change [1] for Keystone whose tests are<br>
failing, since<br>
some tempest changes are made asumptions bases on the old behaviour.<br>
<br>
The proposed change increases the length of the user's name in<br>
the DB<br>
up to 128 characters, instead of 64. Tempest is trying to create<br>
a user<br>
with a username of lenght 65 and expects it to fail.<br>
<br>
How should I proceed? Should I submit a change to tempest to fix<br>
this,<br>
even before knowing if my original change seems reasonable to be<br>
merged?<br>
Should I wait for my change to get some feedback before sending the<br>
modified test for tempest?<br>
<br>
Regards,<br>
Alvaro.<br>
<br></div>
[1] <a href="https://review.openstack.org/#__/c/22694/" target="_blank">https://review.openstack.org/#<u></u>__/c/22694/</a><div class="im"><br>
<<a href="https://review.openstack.org/#/c/22694/" target="_blank">https://review.openstack.org/<u></u>#/c/22694/</a>><br>
<br>
<br>
Typically the route is propose the tempest change, and get core<br>
contributors from the core project (this time keystone) to +1 it<br>
(saying that they agree with the change).<br>
<br>
The core team for keystone would need to believe that this doesn't<br>
represent an API change without a version bump. And that<br>
python-keystoneclient would do the right things with a new client on<br>
an older system. But I'll leave that up to them.<br>
<br>
<br>
This definitely doesn't represent an API change, and would be backwards<br>
compatible with existing clients (this validation is only performed<br>
server side, anyway).<br>
<br>
Following Chmouel's comment on the review, I'm wondering if it would be<br>
possible to preserve the existing default but make this value<br>
configurable moving forward (which would mean no changes in tempest).<br>
I'll save that discussion for the code review, but wanted to mention the<br>
possibility of not affecting tempest here.<br>
</div></blockquote>
<br>
Making this configurable seems like a bad idea from a cross cloud compatibility perspective. If your application that creates users depends on a certain user name size, then can't be used on other clouds because they set their default too low, then that would be an issue.<br>
<br>
Why not just bump it to 255, which is a reasonable db threshold, and be done with it.</blockquote><div><br></div><div>Even better, if that works for LDAP</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class=""><div class="h5"><br>
<br>
-Sean<br>
<br>
-- <br>
Sean Dague<br>
<a href="http://dague.net" target="_blank">http://dague.net</a><br>
<br>
______________________________<u></u>_________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.<u></u>org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev</a><br>
</div></div></blockquote></div><br></div></div>