<div dir="ltr"><div class="im" style="font-family:arial,sans-serif;font-size:13px">That way all gate tests will patch and at the end when Quantum references all group names in lowercase, we can remove the duplicated inisets in devstack.<br>
<div><br></div></div><div style="font-family:arial,sans-serif;font-size:13px">s/patch/pass/g</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Thu, May 23, 2013 at 11:41 AM, Zhongyue Luo <span dir="ltr"><<a href="mailto:zhongyue.nah@intel.com" target="_blank">zhongyue.nah@intel.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi team,<div><br></div><div>First of all, I apologize to the QA team for not communicating with you.</div>
<div>I implemented oslo bp cfg-lowercase-group and caused the frustration of Quantum not working well with Devstack.</div>
<div><br></div><div>Let me first share what I was thinking when writing the Quantum patches to change group names to lowercase.</div><div>As of oslo.config 1.2.0, all group names in conf files will be normalized to lowercase in order to have consistent group name formats across OpenStack projects.</div>
<div>And since the conf files had to be backwards compatible, the original plan was to normalize the group names when read from the conf files and referenced in the code.</div><div>However, we decided to only normalize group names when read since projects which were using capital group names can fix to reference lowercase group names in Havana.</div>
<div>And the patch merged in oslo.config</div><div><br></div><div>Now Quantum trunk had to reference group names in lowercase in order to use oslo.config 1.2.0.</div><div>And to ease code reviewing load, I started changing each capital letter group names to lowercase.</div>
<div>This went well until I realized I didn't consider devstack in gating.</div><div><br></div><div>So here is the solution I propose.</div><div><br></div><div>#1</div><div>To resolve this situation I was planning to write patches to DevStack where it does the same iniset of quantum options in capital letter groups again in lowercase groups.</div>
<div>That way all gate tests will patch and at the end when Quantum references all group names in lowercase, we can remove the duplicated inisets in devstack.</div><div><br></div><div>#2</div><div>
Another solution is for me to send in one huge patch to Quantum which 1) updates oslo.config to 1.2.0 and 2) changes all group name references in to lowercase.</div><div><br></div><div>Sorry again for the confusion. Let me know what you think.</div>
<div><br></div></div><div class="gmail_extra"><div><div class="h5"><br><br><div class="gmail_quote">On Thu, May 23, 2013 at 10:19 AM, Clark Boylan <span dir="ltr"><<a href="mailto:clark.boylan@gmail.com" target="_blank">clark.boylan@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>On Wed, May 22, 2013 at 6:51 PM, Robert Collins<br>
<<a href="mailto:robertc@robertcollins.net" target="_blank">robertc@robertcollins.net</a>> wrote:<br>
>> So should devstack be doing this? And even if it did, I think this<br>
>> will break the way Robert is deploying. I think this change may<br>
>> need some more thought it appears.<br>
><br>
> I believe that is because Quantum still only lists 1.1.0 as a<br>
> dependency: the gate uses trunk rather than the pip installed<br>
> dependencies, which means the gate couldn't detect this (assuming<br>
> 1.1.1 does fix it).<br>
><br>
> FWIW we don't deploy via devstack, but the process is fairly similar:<br>
> grab trunk, install it with deps from pypi + packages for openvswitch<br>
> etc, then go : so while there weren't tests to trigger it, my concern<br>
> is that the gate setup wouldn't detect the problem *even with tests*,<br>
> because the problem is a requirement file that isn't being honoured<br>
> due to the gate setup.<br>
><br>
</div>I double checked this by reading the devstack-gate logs and checking<br>
the projects list at [1]. And as far as I can tell oslo.config is<br>
installed as a normal dependency with pip from pypi (or our mirror).<br>
oslo.config would need to be in that projects list for it to be<br>
installed from source in the gate. So not quite trunk, but it isn't<br>
1.1.0 either as 1.1.1 is available and pip prefers to use that<br>
version.<br>
<br>
[1] <a href="https://github.com/openstack-infra/devstack-gate/blob/master/devstack-vm-gate-wrap.sh#L22" target="_blank">https://github.com/openstack-infra/devstack-gate/blob/master/devstack-vm-gate-wrap.sh#L22</a><br>
<span><font color="#888888"><br>
Clark<br>
</font></span><div><div><br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div><b>Intel SSG/SSD/STO/DCST/CIT</b></div>
<div>880 Zixing Road, Zizhu Science Park, Minhang District, 200241, Shanghai,
China<br></div>
<div><a href="tel:%2B862161166500" value="+862161166500" target="_blank">+862161166500</a></div>
</font></span></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div><b>Intel SSG/SSD/STO/DCST/CIT</b></div>
<div>880 Zixing Road, Zizhu Science Park, Minhang District, 200241, Shanghai,
China<br></div>
<div>+862161166500</div>
</div>