<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body dir="auto">
<div>On May 18, 2013, at 8:18 PM, "Monty Taylor" <<a href="mailto:mordred@inaugust.com">mordred@inaugust.com</a>> wrote:</div>
<blockquote type="cite">
<div><span></span><br>
<span></span><br>
<span>On 05/18/2013 11:09 AM, Melanie Witt wrote:</span><br>
<blockquote type="cite"><span>Hi Monty,</span><br>
</blockquote>
<blockquote type="cite"><span></span><br>
</blockquote>
<blockquote type="cite"><span>Thanks for sending this out.</span><br>
</blockquote>
<blockquote type="cite"><span></span><br>
</blockquote>
<blockquote type="cite"><span>I picked up this update and had a couple of minor issues.</span><br>
</blockquote>
<span></span><br>
<span>Which project?</span><br>
</div>
</blockquote>
<div><br>
</div>
Sorry, I forgot to mention I'm working with nova.
<div><br>
<blockquote type="cite">
<div><span></span>
<blockquote type="cite"><span>1. It broke run_tests.sh, which I know there's been talk of not</span><br>
</blockquote>
<blockquote type="cite"><span>supporting going forward but just to let you know. I was able to run</span><br>
</blockquote>
<blockquote type="cite"><span>tox instead with success.</span><br>
</blockquote>
<span></span><br>
<span>The ones where it broke run_tests.sh are bugs. I think that should be</span><br>
<span>fixed across the board now - but if it's still broken, please let me know.</span><br>
<span></span><br>
<span>It's also an easy patch to run_tests.sh - take the contents of</span><br>
<span>run_pep8() function in the script and simply replace it with ${wrapper}</span><br>
<span>flake8 - because it'll pull the config in.</span><br>
</div>
</blockquote>
<div><br>
</div>
Ok, thanks. In nova/run_tests.sh it wants to run tools/run_pep8.sh which has been removed.</div>
<div><br>
<blockquote type="cite">
<div>
<blockquote type="cite"><span>2. If I don't have python2.7 installed, I need to add importlib to</span><br>
</blockquote>
<blockquote type="cite"><span>tools/test-requires to get it installed in the venv.</span><br>
</blockquote>
<span></span><br>
<span>That seems like a bug in general in the test-requires (or the pip</span><br>
<span>requires- OR - oh, are you saying that flake8 itself on python2.6 is</span><br>
<span>missing importlib? I think you are. Ok. I think I can fix that in</span><br>
<span>hacking - thanks!)</span><br>
</div>
</blockquote>
<div><br>
</div>
Well, it's that importlib is part of the standard library in python2.7 but not python2.6. I'm not sure how this could be handled, I had found this: <a href="http://stackoverflow.com/questions/9418064/conditionally-installing-importlib-on-python2-6">http://stackoverflow.com/questions/9418064/conditionally-installing-importlib-on-python2-6</a></div>
<div><br>
<blockquote type="cite">
<div><span></span>
<blockquote type="cite"><span>Melanie</span><br>
</blockquote>
<blockquote type="cite"><span></span><br>
</blockquote>
<blockquote type="cite"><span>On May 16, 2013, at 7:29 PM, "Monty Taylor" <<a href="mailto:mordred@inaugust.com">mordred@inaugust.com</a>></span><br>
</blockquote>
<blockquote type="cite"><span>wrote:</span><br>
</blockquote>
<blockquote type="cite"><span></span><br>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span>Hey all!</span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span></span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span>As you have all probably noticed, we're moving to using flake8 to</span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span>run pep8/pyflakes/hacking checks. It's awesome and fills the worlds</span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span>with magical ponies and flying cars. BUT - I realized that it's</span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span>possible that perhaps people don't read all of the documentation</span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span>for everything. So I wanted to share a quick trick.</span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span></span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span>flake8, in a fit of amazingness normally not found in python</span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span>utilities, knows how to read other people's config files. So - it</span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span>actually reads the config section in tox.ini even when it's not in</span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span>a venv. That means that, if your project has migrated to flake8</span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span>(that's most of you now) just running:</span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span></span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span>flake8</span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span></span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span>Will get you a flake8 run with all the right options and includes</span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span>and excludes and everything. No wrapper scripts, no fake meat -</span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span>only pure bacon. (you have to have flake8 installed, natch)</span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span></span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span>Your friendly infra guy...</span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span></span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span>Monty</span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span></span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span>_______________________________________________ OpenStack-dev</span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span>mailing list <a href="mailto:OpenStack-dev@lists.openstack.org">
OpenStack-dev@lists.openstack.org</a> </span><br>
</blockquote>
</blockquote>
<blockquote type="cite">
<blockquote type="cite"><span><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a></span><br>
</blockquote>
</blockquote>
<blockquote type="cite"><span></span><br>
</blockquote>
<blockquote type="cite"><span>_______________________________________________ OpenStack-dev mailing</span><br>
</blockquote>
<blockquote type="cite"><span>list <a href="mailto:OpenStack-dev@lists.openstack.org">
OpenStack-dev@lists.openstack.org</a> </span><br>
</blockquote>
<blockquote type="cite"><span><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a></span><br>
</blockquote>
<blockquote type="cite"><span></span><br>
</blockquote>
<span></span><br>
<span>_______________________________________________</span><br>
<span>OpenStack-dev mailing list</span><br>
<span><a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a></span><br>
<span><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a></span><br>
</div>
</blockquote>
</div>
</body>
</html>