<div dir="ltr"><div style>Avishay, </div><div style><br></div>Try making and commiting some changes to your new branch.<div><br></div><div style>As for <span style="font-family:arial,sans-serif;font-size:13px"><font color="#000000">lbaas_step1, I would ask you again to look at my patch. </font></span></div>
<div style><span style="font-family:arial,sans-serif;font-size:13px"><font color="#000000">It in fact implements what you call "step1" (plus some more).</font></span></div><div style><span style="font-family:arial,sans-serif;font-size:13px"><font color="#000000"><br>
</font></span></div><div style><span style="font-family:arial,sans-serif;font-size:13px"><font color="#000000">Thanks,</font></span></div><div style><span style="font-family:arial,sans-serif;font-size:13px"><font color="#000000">Eugene.</font></span></div>
</div><div class="gmail_extra"><br><br><div class="gmail_quote">On Mon, May 13, 2013 at 2:40 PM, Avishay Balderman <span dir="ltr"><<a href="mailto:AvishayB@radware.com" target="_blank">AvishayB@radware.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple">
<div>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Hi<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">I followed
</span><a href="https://wiki.openstack.org/wiki/GerritWorkflow#Add_dependency" target="_blank">https://wiki.openstack.org/wiki/GerritWorkflow#Add_dependency</a><u></u><u></u></p>
<p class="MsoNormal">and got:<u></u><u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><span style="color:#1f497d">avishayb@ubuntu:~/quantum$ git fetch
<a href="https://review.openstack.org/openstack/quantum" target="_blank">https://review.openstack.org/openstack/quantum</a> refs/changes/45/28245/9 && git checkout FETCH_HEAD<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">From <a href="https://review.openstack.org/openstack/quantum" target="_blank">
https://review.openstack.org/openstack/quantum</a><u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">* branch refs/changes/45/28245/9 -> FETCH_HEAD<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">Note: checking out 'FETCH_HEAD'.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">You are in 'detached HEAD' state. You can look around, make experimental<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">changes and commit them, and you can discard any commits you make in this<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">state without impacting any branches by performing another checkout.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">If you want to create a new branch to retain commits you create, you may<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">do so (now or later) by using -b with the checkout command again. Example:<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d"> git checkout -b new_branch_name<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">HEAD is now at d906d80... multi-vendor-support-for-lbaas<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">avishayb@ubuntu:~/quantum$ git checkout -b lbaas_step1<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">Switched to a new branch 'lbaas_step1'<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">avishayb@ubuntu:~/quantum$ git branch --list<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">* lbaas_step1<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d"> master<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">avishayb@ubuntu:~/quantum$ git review -R<u></u><u></u></span></p>
<p class="MsoNormal"><span style="color:#1f497d">remote: Processing changes: refs: 1, done
<u></u><u></u></span></p>
<p class="MsoNormal"><b><span style="color:#1f497d">To ssh://<a href="http://avishayb@review.openstack.org:29418/openstack/quantum.git" target="_blank">avishayb@review.openstack.org:29418/openstack/quantum.git</a><u></u><u></u></span></b></p>
<p class="MsoNormal"><b><span style="color:#1f497d">! [remote rejected] HEAD -> refs/for/master/bp/multi-vendor-support-for-lbaas-step0 (no new changes)<u></u><u></u></span></b></p>
<p class="MsoNormal"><b><span style="color:#1f497d">error: failed to push some refs to 'ssh://<a href="http://avishayb@review.openstack.org:29418/openstack/quantum.git" target="_blank">avishayb@review.openstack.org:29418/openstack/quantum.git</a>'<u></u><u></u></span></b></p>
<p class="MsoNormal"><span style="color:#1f497d"><u></u> <u></u></span></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Any idea?<u></u><u></u></p><div class="im">
<p class="MsoNormal"><u></u> <u></u></p>
<p class="MsoNormal">Avishay<span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p>
<div style="border:none;border-top:solid #b5c4df 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Eugene Nikanorov [mailto:<a href="mailto:enikanorov@mirantis.com" target="_blank">enikanorov@mirantis.com</a>]
<br>
<b>Sent:</b> Monday, May 13, 2013 11:32 AM<br>
<b>To:</b> OpenStack Development Mailing List<br>
<b>Subject:</b> Re: [openstack-dev] Working on the next patch while the current one in under review - git & gerrit question<u></u><u></u></span></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div><div>
<p class="MsoNormal">Hi Avishay,<u></u><u></u></p><div><div class="h5">
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Before moving forward, make sure you're not duplicating <a href="https://review.openstack.org/#/c/28289/" target="_blank">https://review.openstack.org/#/c/28289/</a><u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Regarding working on dependent patches please refer to <a href="https://wiki.openstack.org/wiki/GerritWorkflow" target="_blank">https://wiki.openstack.org/wiki/GerritWorkflow</a> section "Add dependency" at the bottom.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
<div>
<p class="MsoNormal">Thanks,<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal">Eugene.<u></u><u></u></p>
</div>
<div>
<p class="MsoNormal"><u></u> <u></u></p>
<div>
<p class="MsoNormal">On Mon, May 13, 2013 at 12:10 PM, Avishay Balderman <<a href="mailto:AvishayB@radware.com" target="_blank">AvishayB@radware.com</a>> wrote:<u></u><u></u></p>
<p class="MsoNormal">Hi<br>
I have a patch which is under review.<br>
I want to start and work on the next patch. The next patch is based on the one that is still under review.<br>
What is the best strategy to achieve that? The assumption is that I will have to work on both patches on parallel.<br>
<br>
Thanks<br>
<br>
Avishay<br>
<br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><u></u><u></u></p>
</div>
<p class="MsoNormal"><u></u> <u></u></p>
</div>
</div></div></div>
</div>
</div>
<br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>