<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On May 10, 2013, at 7:40 AM, Akihiro MOTOKI wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><meta http-equiv="Content-Type" content="text/html; charset=Windows-1252"><div dir="ltr">Hi Paul,<div><br></div><div>2013/5/10 Paul Michali <span dir="ltr"><<a href="mailto:pcm@cisco.com" target="_blank">pcm@cisco.com</a>></span><br></div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">Seeking advice on handling here…<div><br></div><div>Both are about subnet create not checking if gateway is in subnet.</div><div><br></div><div>1178136 appears to be a duplicate of 1078490. <b>How do I disposition 1178136? Mark invalid?</b></div>
</div></blockquote><div><br></div><div style="">In such case "Mark as duplicate" is the best way. I marked 1178136 as duplicate.</div></div></div></div></blockquote><div><br></div>PCM: I didn't see that as one of the status selections. Where did you go to mark it as a duplicate.</div><div><br></div><div><br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div></div><div>1078490 appears to be a configuration error. There is a flag in quantum.conf that indicates whether or not the GW must be within the subnet or not. <b>How do I disposition 1078490? Invalid?</b></div>
</div></blockquote><div><br></div><div style="">I have not sort out my opinion yet... I will comment on the bug later.</div></div></div></div></blockquote><div><br></div>PCM: OK, let me know. Seems like a config error, as the user could just set the flag in quantum.conf to get the checking.</div><div><br></div><div><br><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div>Note, I checked the unit tests and there IS a test case where the force_gateway_on_subnet flag is set and then a test is made to make sure that the GW IP is within the subnet being created. However, there are no negative test cases (GW=subnet, GW=BCAST address, and GW not in subnet). <b>Should I add mark the bug in progress and add the test cases. instead of trashing the bug?</b></div>
</div></blockquote><div><br></div><div style="">Is it related to the above bug? IMO the lack of the unit test is another bug.</div></div></div></div></blockquote><div><br></div>PCM: I looked closer at the UTs, it looks like there is some coverage after all. From what I see, there is no test of a GW set to the network IP and set to the BCAST address, both of which are rejected, if that flag is set. Somewhat minor conditions.</div><div><br></div><div>There also isn't a test of subnet_update(), with the force GW flag set and the GW out of range. subnet_update() shares the same validate function, so this probably isn't needed.</div><div><br></div><div>We could use this opportunity to add 2-3 UTs, or just close as config error (not a bug).</div><div><br></div><div>Let me know what you think. Thanks!</div><div><br></div><div>PCM (Paul Michali)</div><div><br></div><div><br></div><div><br></div><div><blockquote type="cite"><div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div style=""><br></div><div style="">Thanks,</div><div style="">Akihiro</div><div style=""> <br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word"><div><br></div><div>Regards,</div><div><br><div>
<span style="text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:-webkit-auto;font-style:normal;font-weight:normal;line-height:normal;border-collapse:separate;text-transform:none;font-size:medium;white-space:normal;font-family:Helvetica;word-spacing:0px">PCM (Paul Michali)<br>
<br></span></div></div></div><br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br>Akihiro MOTOKI <<a href="mailto:amotoki@gmail.com" target="_blank">amotoki@gmail.com</a>>
</div></div>
_______________________________________________<br>OpenStack-dev mailing list<br><a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev<br></blockquote></div><br></body></html>