I've addressed the last one related to health monitor parameters. The review is: <a href="https://review.openstack.org/#/c/23815/" target="_blank">https://review.openstack.org/#/c/23815/</a><div><br></div><div>Ilya</div>
<div><br>
<div class="gmail_quote">2013/3/6 Kuang-Ching Wang <span dir="ltr"><<a href="mailto:kc.wang@bigswitch.com" target="_blank">kc.wang@bigswitch.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">Thanks, Ilya, for the helpful comments.<div><br></div><div>I have addressed three of the following suggestions, and left one for future work as I'm running out of bandwidth. Specific comments below. I have just pushed a new patch to gerrit.</div>
<div><br></div><div>KC</div><div><br></div><div><div><div><div><div>On Mar 5, 2013, at 6:01 AM, Ilya Shakhat wrote:</div><br><blockquote type="cite">Hi KC, <div><br></div><div>It's great to see LBaaS support in Horizon! I hope it is not too late to get it merged into Grizzly, is it?</div>
<div><br></div><div>Here are some issues I found during testing (they are not top-critical, but nice-to-haves):</div>
<div>* Some required fields are actually non-mandatory, i.e. description, session persistence parameters</div></blockquote><div><br></div></div><div>Made these not required and proper conditioning at the end.</div><div>
<br><blockquote type="cite"><div>* On "Add member" screen it is possible to select multiple members, but only the first is added into the pool</div></blockquote><div><br></div></div><div>Corrected this.</div><div>
<br><blockquote type="cite">
<div>* Health monitor parameters should depend on type of monitor, e.g. for PING type parameters HTTP Method and URL are not needed</div></blockquote><div><br></div></div><div>Future work to make the menu dynamic based on choice of monitor type.</div>
<div><br><blockquote type="cite"><div>* 'Port' field on member and vip details screens should be renamed to 'Protocol Port' (in order to correspond to the last-minute change in API and client)</div>
</blockquote><div><br></div></div>Corrected.</div><div><div><br><blockquote type="cite">
<div><br></div><div>Thanks,</div><div>Ilya<br><br><div class="gmail_quote">2013/3/5 Kuang-Ching Wang <span dir="ltr"><<a href="mailto:kc.wang@bigswitch.com" target="_blank">kc.wang@bigswitch.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div style="word-wrap:break-word">Hi all,<div><br></div><div>many of you may have viewed the "Quantum/LBaaS/HowToRun" page for the newly added quantum LBaaS support. Now you can also try out its Horizon support. Instructions are added to the same page: <a href="https://wiki.openstack.org/wiki/Quantum/LBaaS/HowToRun" target="_blank">https://wiki.openstack.org/wiki/Quantum/LBaaS/HowToRun</a> </div>
<div><br></div><div>Questions and suggestions are welcome.</div><div><br></div><div>Thanks,</div><div>KC<br><div>
<span style="text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:-webkit-auto;font-style:normal;font-weight:normal;line-height:normal;border-collapse:separate;text-transform:none;font-size:medium;white-space:normal;font-family:Helvetica;word-spacing:0px"><span style="text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:-webkit-auto;font-style:normal;font-weight:normal;line-height:normal;border-collapse:separate;text-transform:none;font-size:medium;white-space:normal;font-family:Helvetica;word-spacing:0px"><div style="word-wrap:break-word">
<span style="text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:-webkit-auto;font-style:normal;font-weight:normal;line-height:normal;border-collapse:separate;text-transform:none;font-size:medium;white-space:normal;font-family:Helvetica;word-spacing:0px"><div style="word-wrap:break-word">
<span style="text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:-webkit-auto;font-style:normal;font-weight:normal;line-height:normal;border-collapse:separate;text-transform:none;font-size:medium;white-space:normal;font-family:Helvetica;word-spacing:0px"><div style="word-wrap:break-word">
<span style="text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:-webkit-auto;font-style:normal;font-weight:normal;line-height:normal;border-collapse:separate;text-transform:none;font-size:medium;white-space:normal;font-family:Helvetica;word-spacing:0px"><div style="word-wrap:break-word">
<div><div>--</div><div>Kuang-Ching (KC) Wang</div><div>Member of Technical Staff -- Big Switch Networks -- <a href="http://www.bigswitch.com/" target="_blank">http://www.bigswitch.com/</a></div></div><div><br></div></div>
</span><br></div></span><br></div></span><br></div></span><br></span><br>
</div>
<br></div></div><br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>
_______________________________________________<br>OpenStack-dev mailing list<br><a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.org</a><br><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div><br><div>
<span style="text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:-webkit-auto;font-style:normal;font-weight:normal;line-height:normal;border-collapse:separate;text-transform:none;font-size:medium;white-space:normal;font-family:Helvetica;word-spacing:0px"><span style="text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:-webkit-auto;font-style:normal;font-weight:normal;line-height:normal;border-collapse:separate;text-transform:none;font-size:medium;white-space:normal;font-family:Helvetica;word-spacing:0px"><div style="word-wrap:break-word">
<span style="text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:-webkit-auto;font-style:normal;font-weight:normal;line-height:normal;border-collapse:separate;text-transform:none;font-size:medium;white-space:normal;font-family:Helvetica;word-spacing:0px"><div style="word-wrap:break-word">
<span style="text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:-webkit-auto;font-style:normal;font-weight:normal;line-height:normal;border-collapse:separate;text-transform:none;font-size:medium;white-space:normal;font-family:Helvetica;word-spacing:0px"><div style="word-wrap:break-word">
<span style="text-indent:0px;letter-spacing:normal;font-variant:normal;text-align:-webkit-auto;font-style:normal;font-weight:normal;line-height:normal;border-collapse:separate;text-transform:none;font-size:medium;white-space:normal;font-family:Helvetica;word-spacing:0px"><div style="word-wrap:break-word">
<div><div>--</div><div>Kuang-Ching (KC) Wang</div><div>Member of Technical Staff -- Big Switch Networks -- <a href="http://www.bigswitch.com/" target="_blank">http://www.bigswitch.com/</a></div></div><div><br></div></div>
</span><br></div></span><br></div></span><br></div></span><br></span><br>
</div>
<br></div></div></div></div><br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>