<div class="gmail_quote">On Thu, Feb 21, 2013 at 12:24 PM, Eric Windisch <span dir="ltr"><<a href="mailto:eric@cloudscaling.com" target="_blank">eric@cloudscaling.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The more I think about this, the more I think the solution might be:<br>
<br>
1. (Grizzly) Merge an AMQP-specific check<br>
2. (Havana) Merge a message-signing oriented check which will:<br>
a) refactor the AMQP-specific check for DYI purposes, without significantly affecting its behavior or functionality except as otherwise noted below.<br>
b) make the AMQP-specific check disable itself if message-signing is enabled.<br>
c) enable a duplicate-check in rpc-common if message-signing is enabled.<br>
<br>
I think this will eliminate both my own concerns for the long-term, the concerns regarding ease-of-configuration, as well as the immediate concerns for Grizzly.<br>
<br>
We'd be eliminating any significant duplication of code through reusing the implementation, preventing concerns of forward/backward compatibility or double-checking by simply disabling the AMQP-specific code-path when the not-backwards-compatible message-signing feature is enabled.<br>
</blockquote><div><br>Sounds good to me and it looks like we're headed down that path with <a href="https://review.openstack.org/20567" target="_blank">https://review.openstack.org/20567</a>: <span class="gwt-InlineLabel">"Needs to skip duplicated messages when using rabbitmq mirrored queue" <br>
<br>Ray<br></span></div></div>