<br><br><div class="gmail_quote">On Wed, Feb 20, 2013 at 9:16 PM, Monty Taylor <span dir="ltr"><<a href="mailto:mordred@inaugust.com" target="_blank">mordred@inaugust.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hey all!<br>
<br>
I'm working through Quantum patches to migrate unittests to testtools as<br>
step one in getting the testr parallel test running in place.<br>
Unfortunately for me, you are all WAY to productive and write more tests<br>
than I can keep up with the conversion of. :)<br></blockquote><div><br></div><div>Hooray!</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
To that end, I'd like to ask if folks could start doing the following to<br>
help:<br>
<br>
- If you add new tests and as part of doing that you add a setUp or a<br>
tearDown method - PLEASE add an upcall. This is going to be enforced by<br>
testtools soon anyway, so it's good to get in the habit<br>
<br>
- If you aren't overriding things in those methods, don't add them. For<br>
instance:<br>
<br>
def tearDown(self):<br>
pass<br>
<br>
is a bad idea - just leave it out<br>
<br>
(also - thanks for being so great about writing tests - it's an awesome<br>
problem to have)<br></blockquote><div><br></div><div><br></div><div>Got it. Folks, let's make sure we start enforcing this as part of the review process. </div><div><br></div><div>Dan</div><div><br></div><div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Monty<br>
<br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div><br><br clear="all"><div><br></div>-- <br>~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>Dan Wendlandt <div>Nicira, Inc: <a href="http://www.nicira.com" target="_blank">www.nicira.com</a><br><div>twitter: danwendlandt<br>
~~~~~~~~~~~~~~~~~~~~~~~~~~~<br></div></div>