<br><br><div class="gmail_quote">On Fri, Jan 25, 2013 at 10:06 AM, Sean Dague <span dir="ltr"><<a href="mailto:sdague@linux.vnet.ibm.com" target="_blank">sdague@linux.vnet.ibm.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 01/25/2013 09:14 AM, Daniel P. Berrange wrote:<br>
<snip><div class="im"><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
IMHO, LOG.error/warn/info can be marked for translation, since those<br>
are used for scenarios where we are trying to alert the sysadmin to<br>
something, but LOG.debug should be left untranslated as they are for<br>
vendors/developers primarily.<br>
<br>
In other words, if we remove translation from all LOG.debug() messages,<br>
I'd be fine with a string freeze on what's left.<br>
</blockquote>
<br></div>
A lot of that has come from not having a formal policy on what's translatable, so it's all adhoc, and eventually that's where we've gotten to.<br>
<br>
I'd be +1 on to LOG.error/warn/info as i18n, and LOG.debug to have that removed if we could bake that into policy. There would still be time to fix that for grizzly, and maybe even get a hacking.py extension to check for and enforce that.</blockquote>
<div><br></div><div><br></div><div>+1</div><div><br></div><div>A quick git grep in nova shows that about half the LOG messages are LOG.debug, so not translating them should have a significant impact on the number of strings requiring translation.</div>
<div><br></div><div><div>nova$ git grep "LOG\.error" | wc </div><div> 129 795 11477</div><div>nova$ git grep "LOG\.warn" | wc </div><div> 150 1023 13736</div><div>$ git grep "LOG\.info" | wc </div>
<div> 184 1107 16886</div><div>nova$ git grep "LOG\.debug" | wc </div><div> 689 4141 63752</div></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class="HOEnZb"><font color="#888888"><br>
<br>
-Sean<br>
<br>
-- <br>
Sean Dague<br>
IBM Linux Technology Center<br>
email: <a href="mailto:sdague@linux.vnet.ibm.com" target="_blank">sdague@linux.vnet.ibm.com</a><br>
alt-email: <a href="mailto:sldague@us.ibm.com" target="_blank">sldague@us.ibm.com</a></font></span><div class="HOEnZb"><div class="h5"><br>
<br>
<br>
______________________________<u></u>_________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.<u></u>org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev</a><br>
</div></div></blockquote></div><br>