Awesome. Skimming through some of the reports, there are certainly areas of zero coverage worthy of bug reports.<div><br></div><div>There's also a job on jenkins to run coverage, but it appears to be broken:</div><div>
<br></div><div> <a href="https://jenkins.openstack.org/view/Keystone/job/keystone-coverage/783/console">https://jenkins.openstack.org/view/Keystone/job/keystone-coverage/783/console</a></div><div><br></div><div>... empty files have 100% coverage and everything else is reporting 0%.<br>
</div><div class="gmail_extra"><br clear="all"><div><br></div>-Dolph<br>
<br><br><div class="gmail_quote">On Tue, Dec 4, 2012 at 9:10 PM, Adam Young <span dir="ltr"><<a href="mailto:ayoung@redhat.com" target="_blank">ayoung@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
I just realized that run_test.sh has an option to generate test coverage. As I go through and do a bit of refactoring, I am painfully aware at how dependent we are on unit tests to make sure we don't break anything.<br>
<br>
Results:<br>
<br>
<a href="http://admiyo.fedorapeople.org/openstack/covhtml/" target="_blank">http://admiyo.fedorapeople.<u></u>org/openstack/covhtml/</a><br>
<br>
I would say that we are not doing too bad. Our total is 81% right now. A good chunk of that comes from Open stack common, where we don't run or test all the code we pull in.<br>
<br>
The worst offenders right now:<br>
<br>
keystone.identity.backends.pam 51%<br>
<br>
This seems odd. I wonder if we are disabling more tests than we should. This backend should be easy to keep up with SQL.<br>
<br>
Some other notables.<br>
<br>
keystone.common.controller 57% Short file, but critical to most other things.<br>
<a href="http://admiyo.fedorapeople.org/openstack/covhtml/keystone_common_controller.html" target="_blank">http://admiyo.fedorapeople.<u></u>org/openstack/covhtml/<u></u>keystone_common_controller.<u></u>html</a><br>
Looks like that should be testing RBAC.<br>
<br>
<br>
SQL tests across the board we need more testing of downgrade.<br>
Example:<br>
<a href="http://admiyo.fedorapeople.org/openstack/covhtml/keystone_common_sql_migrate_repo_versions_004_undo_token_id_hash.html" target="_blank">http://admiyo.fedorapeople.<u></u>org/openstack/covhtml/<u></u>keystone_common_sql_migrate_<u></u>repo_versions_004_undo_token_<u></u>id_hash.html</a><br>
<br>
<br>
keystone.common.ldap.core 73% Paging code is untested. Also, a few of the helper functions at the top look like they are unused and can be removed. I like removing code.<br>
<br>
keystone.common.utils 64% If the utilities are not being used, we should probably remove them.<br>
keystone.identity.core 62% No Big deal: all the un implemented functions.<br>
<br>
So, if you are touching any of these files, try and up the percentage.<br>
<br>
We should review the test coverage in the weekly meeting.<br>
<br>
<br>
______________________________<u></u>_________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.<u></u>org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev</a><br>
</blockquote></div><br></div>