<br><br><div class="gmail_quote">On Wed, Nov 21, 2012 at 12:31 PM, Samuel Merritt <span dir="ltr"><<a href="mailto:sam@swiftstack.com" target="_blank">sam@swiftstack.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5">On 11/21/12 11:03 AM, Monty Taylor wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
On 11/21/2012 10:31 AM, Doug Hellmann wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
On Wed, Nov 21, 2012 at 12:51 PM, Monty Taylor <<a href="mailto:mordred@inaugust.com" target="_blank">mordred@inaugust.com</a><br>
<mailto:<a href="mailto:mordred@inaugust.com" target="_blank">mordred@inaugust.com</a>>> wrote:<br>
<br>
<br>
<br>
On 11/21/2012 09:43 AM, Daniel P. Berrange wrote:<br>
<br>
On Wed, Nov 21, 2012 at 09:26:53AM -0800, Monty Taylor wrote:<br>
<br>
Hey all!<br>
<br>
When you go to add a new repo on github, you get this<br>
message:<br>
<br>
"We recommend that every repository has a README, LICENSE,<br>
CONTRIBUTING, and .gitignore."<br>
<br>
I certainly agree with them on 3 of the 4 - but I've never<br>
really<br>
thought about having a CONTRIBUTING file. It seems like a<br>
good idea<br>
though - especially since we have a kind-of specific<br>
workflow for<br>
contribution.<br>
<br>
What do people think? Should we add that file? In it,<br>
should we<br>
include the text of our contribution instructions, or just a<br>
small<br>
snippet that directs people to the website with a quick<br>
3-second<br>
"sign cla, download git-review, submit"?<br>
<br>
<br>
For most projects I'm involved with this kind of info would<br>
be either in the README file or the HACKING file. I don't<br>
actually remember seeing use of a CONTRIBUTING file before.<br>
<br>
<br>
Yeah, me either - but hell, if it's something github are about to be<br>
pushing people to do, I mean, I don't want to be the one without<br>
skinny jeans and a beard this time around...<br>
<br>
<br>
<a href="https://github.com/blog/1184-contributing-guidelines" target="_blank">https://github.com/blog/1184-<u></u>contributing-guidelines</a><br>
<br>
If we add the files, github will show a "Check the guidelines for<br>
contributing to this repository" link for us and we may avoid having<br>
potential contributors send pull requests (I saw a couple of those go by<br>
this week) instead of following the desired workflow.<br>
</blockquote>
<br>
Ah - ok, that is pretty sexy. Let's do it. I like Russell's suggested<br>
boilerplate.<br>
</blockquote>
<br></div></div>
I like it so much that I stole it and Markdown-formatted it for Swift:<br>
<br>
<a href="https://review.openstack.org/16678" target="_blank">https://review.openstack.org/<u></u>16678</a><br>
<br>
I also threw in a couple sentences to make it clear that pull requests and GitHub issues are not an acceptable alternative to the OpenStack workflow and will be ignored.<br>
<br>
If you want to use that for the other projects, just make sure to change the link in the last paragraph to point to the right bug tracker.<div class="HOEnZb"><div class="h5"><br>
<br>
<br>
______________________________<u></u>_________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.<u></u>org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev</a><br>
</div></div></blockquote></div>And I liked your stolen version so well... I stole it from you and added it to Cinder :)