<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">So is it fair to say at this point that we're standardizing on 1.3.3 for Grizzly?<div><br></div><div>Waldon<br><div><br></div><div><br><div><div>On Nov 20, 2012, at 4:48 PM, Joe Gordon wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><br><br><div class="gmail_quote">On Mon, Nov 19, 2012 at 10:57 PM, Monty Taylor <span dir="ltr"><<a href="mailto:mordred@inaugust.com" target="_blank">mordred@inaugust.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
<br>
On 11/19/2012 09:15 PM, Brian Waldon wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
On Nov 19, 2012, at 4:28 PM, Brian Waldon wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
On Nov 19, 2012, at 4:16 PM, Chuck Short wrote:<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 12-11-19 06:40 PM, Joe Gordon wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
<br>
On Mon, Nov 19, 2012 at 3:06 PM, Monty Taylor<br>
<<a href="mailto:mordred@inaugust.com" target="_blank">mordred@inaugust.com</a> <mailto:<a href="mailto:mordred@inaugust.com" target="_blank">mordred@inaugust.com</a>>> wrote:<br>
<br>
I think these are orthogonal. In general I believe we're in<br>
agreement that we should be targetting the same version of<br>
pep8, and that we should pin that version early in the cycle.<br>
However we install that version of pep8 is a different<br>
argument.<br>
<br>
<br>
Targeting the same version of pep8 is only part of the problem,<br>
we would also need to agree on what rules to ignore. For<br>
example:<br>
<br>
glance (pep8 1.3.3) ignores: E125,E126,E711,E712 nova (pep8<br>
1.2) ignores: E12,E711,E721 keystone (pep8 1.3.3) ignores: ---<br>
</blockquote>
<br>
Is there a reason why these were ignored?<br>
</blockquote>
<br>
I just ran glance's pep8 check without ignoring any errors, and it<br>
appears most of them are just arbitrary spacing. I'll attempt to<br>
minimize the number of pep8 violations we ignore.<br>
</blockquote>
<br>
After walking through the type of errors we're ignoring, I'm not<br>
actually comfortable removing any of the PEP8 violations (E125, E126,<br>
E711, E712) from Glance's ignore list. The first two are quite<br>
fragile and enforce a somewhat awkward coding style, while the second<br>
two are asking us to write code that is incompatible with sqlalchemy.<br>
Hopefully the maintainers will help improve this situation.<br>
</blockquote>
<br></div></div>
What about downgrading our pep8 level to 1.2? It doesn't sound like people are really thrilled in general with 1.3...<div class="HOEnZb"><div class="h5"><br>
<br></div></div></blockquote><div><br></div><div>Nova just bumped to 1.3.3, also there are rules that nova ignores even in 1.2. So going to 1.2 doesn't solve that issue., for example <span style="background-color:rgb(255,255,255);color:rgb(34,34,34);font-family:arial,sans-serif;font-size:13px">E125, E126 are in 1.2</span></div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
______________________________<u></u>_________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.<u></u>org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev</a><br>
</div></div></blockquote></div><br>
_______________________________________________<br>OpenStack-dev mailing list<br><a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev<br></blockquote></div><br></div></div></body></html>