<br><br><div class="gmail_quote">On Wed, Nov 21, 2012 at 12:51 PM, Monty Taylor <span dir="ltr"><<a href="mailto:mordred@inaugust.com" target="_blank">mordred@inaugust.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im"><br>
<br>
On 11/21/2012 09:43 AM, Daniel P. Berrange wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On Wed, Nov 21, 2012 at 09:26:53AM -0800, Monty Taylor wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hey all!<br>
<br>
When you go to add a new repo on github, you get this message:<br>
<br>
"We recommend that every repository has a README, LICENSE,<br>
CONTRIBUTING, and .gitignore."<br>
<br>
I certainly agree with them on 3 of the 4 - but I've never really<br>
thought about having a CONTRIBUTING file. It seems like a good idea<br>
though - especially since we have a kind-of specific workflow for<br>
contribution.<br>
<br>
What do people think? Should we add that file? In it, should we<br>
include the text of our contribution instructions, or just a small<br>
snippet that directs people to the website with a quick 3-second<br>
"sign cla, download git-review, submit"?<br>
</blockquote>
<br>
For most projects I'm involved with this kind of info would<br>
be either in the README file or the HACKING file. I don't<br>
actually remember seeing use of a CONTRIBUTING file before.<br>
</blockquote>
<br></div>
Yeah, me either - but hell, if it's something github are about to be pushing people to do, I mean, I don't want to be the one without skinny jeans and a beard this time around...</blockquote><div><br></div><div><a href="https://github.com/blog/1184-contributing-guidelines">https://github.com/blog/1184-contributing-guidelines</a></div>
<div><br></div><div>If we add the files, github will show a "Check the guidelines for contributing to this repository" link for us and we may avoid having potential contributors send pull requests (I saw a couple of those go by this week) instead of following the desired workflow.</div>
<div><br></div><div>Doug</div><div><br></div></div>