Thanks for comments Youcef!<div><br></div><div>I've updated document with proposed changes. "tenant-id" attribute is added for all creation commands. Also I've noticed that there is "description" attribute in REST API pool update command, so I've added it for both "lb-pool-update" and "lb-pool-create" commands.</div>
<div><br></div><div>As of keystone interaction - the client already supports both token and env. variables, so there is nothing to change here.</div><div><br></div><div>Thanks,</div><div>Ilya<br><br><div class="gmail_quote">
2012/11/14 Youcef Laribi <span dir="ltr"><<a href="mailto:Youcef.Laribi@eu.citrix.com" target="_blank">Youcef.Laribi@eu.citrix.com</a>></span><br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="blue" vlink="purple"><div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Looks great Ilya! <u></u><u></u></span></p><p class="MsoNormal">
<span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">A few small comments below:<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p style="margin-left:38.25pt"><u></u><span style="font-size:11.0pt;font-family:Symbol;color:#1f497d"><span>·<span style="font:7.0pt "Times New Roman""> </span></span></span><u></u><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">On </span><span style="font-size:11.0pt;font-family:"Courier New"">lb-pool-create</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> <span style="color:#1f497d">command, the arguments are not optional, they have to be specified.<u></u><u></u></span></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><div style="border:solid #aebdcc 1.0pt;padding:5.0pt 5.0pt 5.0pt 5.0pt;background:#f3f5f7">
<p class="MsoNormal" style="line-height:12.25pt;background:#f3f5f7;border:none;padding:0in"><span style="font-size:11.0pt;font-family:Courier;color:#535353">lb-pool-create [--network-id <network-id>] [--lb-method <lb-method>] [--protocol <protocol>] <name><u></u><u></u></span></p>
</div><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p style="margin-left:38.25pt"><u></u><span style="font-size:11.0pt;font-family:Symbol;color:#1f497d"><span>·<span style="font:7.0pt "Times New Roman""> </span></span></span><u></u><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">The type of the health-monitor cannot be updated.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><div style="border:solid #aebdcc 1.0pt;padding:5.0pt 5.0pt 5.0pt 5.0pt;background:#f3f5f7">
<pre style="line-height:12.25pt;background:#f3f5f7;border:none;padding:0in"><span style="font-size:11.0pt;font-family:Courier;color:#535353">lb-healthmonitor-update </span><span style="font-size:11.0pt;font-family:Courier;color:red">[--type <type>] </span><span style="font-size:11.0pt;font-family:Courier;color:#535353">[--delay <delay>] [--max_retries <max_retries>] [--timeout <timeout>] [--name <name>] [--http_method <http method>] [--path <path>] [--expected-codes <expected codes>] <healthmonitor-id><u></u><u></u></span></pre>
</div><p class="MsoNormal" style="text-align:start;word-spacing:0px"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p style="margin-left:38.25pt">
<u></u><span style="font-size:11.0pt;font-family:Symbol;color:#1f497d"><span>·<span style="font:7.0pt "Times New Roman""> </span></span></span><u></u><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">There is also the “description” field missing in the </span><span style="font-size:11.0pt;font-family:"Courier New"">lb-vip-create</span><span style="font-size:11.0pt;font-family:"Calibri","sans-serif""> <span style="color:#1f497d">command.<u></u><u></u></span></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Also for all the create commands, we should support supplied a “tenant_id” attribute when an admin is creating resources for another tenant (API supports supplying this).<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">BTW, how is the tenant keystone token specified? are we going to use env. variables ?<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></p><p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Thanks<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d">Youcef<u></u><u></u></span></p><p class="MsoNormal"><a name="13b007244427951e__MailEndCompose"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1f497d"><u></u> <u></u></span></a></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Ilya Shakhat [mailto:<a href="mailto:ishakhat@mirantis.com" target="_blank">ishakhat@mirantis.com</a>] <br>
<b>Sent:</b> Wednesday, November 14, 2012 8:51 AM<br><b>To:</b> OpenStack Development Mailing List (<a href="mailto:openstack-dev@lists.openstack.org" target="_blank">openstack-dev@lists.openstack.org</a>)<br><b>Subject:</b> [openstack-dev] [Quantum][LBaaS] LBaaS extension for python-quantumclient<u></u><u></u></span></p>
<div><div class="h5"><p class="MsoNormal"><u></u> <u></u></p><p class="MsoNormal">Hi!<u></u><u></u></p><div><p class="MsoNormal"><u></u> <u></u></p></div><div><p class="MsoNormal">Please review the draft specification on LBaaS CLI (<a href="http://wiki.openstack.org/Quantum/LBaaS/CLI" target="_blank">http://wiki.openstack.org/Quantum/LBaaS/CLI</a>). It is based on service REST API, all new commands start with "lb_' prefix. <u></u><u></u></p>
</div><div><p class="MsoNormal"><u></u> <u></u></p></div><div><p class="MsoNormal">Thanks,<u></u><u></u></p></div><div><p class="MsoNormal">Ilya<u></u><u></u></p></div></div></div></div></div><br>_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
<br></blockquote></div><br></div>