<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="ZH-CN" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">Doug, thanks for reply.
<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">It’s logging module failed to print anything other than this warning. The issue happens in followed code on _load_plugins() from stevedore/extension.py. If exception happen when loading plugin, while
the code intended to log the exception stacktrace, but it printed only one warning of “"No handler could be found for logger "</span><span lang="EN-US">
<span style="color:#1F497D">stevedore.extension"" printed, no stack trace at all.<o:p></o:p></span></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span lang="EN-US" style="color:#1F497D"> def _load_plugins(self, invoke_on_load, invoke_args, invoke_kwds):<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span lang="EN-US" style="color:#1F497D"> extensions = []<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span lang="EN-US" style="color:#1F497D"> for ep in pkg_resources.iter_entry_points(self.namespace):<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span lang="EN-US" style="color:#1F497D"> LOG.debug('found extension %r', ep)<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span lang="EN-US" style="color:#1F497D"> try:<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span lang="EN-US" style="color:#1F497D"> ext = self._load_one_plugin(ep,<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span lang="EN-US" style="color:#1F497D"> invoke_on_load,<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span lang="EN-US" style="color:#1F497D"> invoke_args,<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span lang="EN-US" style="color:#1F497D"> invoke_kwds,<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span lang="EN-US" style="color:#1F497D"> )<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span lang="EN-US" style="color:#1F497D"> if ext:<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span lang="EN-US" style="color:#1F497D"> extensions.append(ext)<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span lang="EN-US" style="color:#1F497D"> except KeyboardInterrupt:<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span lang="EN-US" style="color:#1F497D"> raise<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span lang="EN-US" style="color:#1F497D"> except Exception as err:<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span lang="EN-US" style="color:#1F497D"> LOG.error('Could not load %r: %s', ep.name, err) >>> not printed<o:p></o:p></span></p>
<p class="MsoNormal" style="margin-left:5.25pt"><span lang="EN-US" style="color:#1F497D"> LOG.exception(err) >>> not printed<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D"> return extensions<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">IMHO, I don’t think stevedore should handle the exception silently. The caller should handle that to be more flexible. Or at least it should know that some plug-in failed to load. Possibly we can
return plugin iterator to caller, and caller load them one by one.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">Possibly we can dsicuss on the stevedore side.<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">Thanks<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="color:#1F497D">--jyh<o:p></o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal" style="margin-left:5.25pt"><span lang="EN-US"><o:p></o:p></span></p>
</div>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US"><br>
<br>
IMHO the _load_plugins() in stevestore.extension should not handle the exception, instead, the caller should do that.<o:p></o:p></span></p>
<div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">Is it actually an exception, or is it just the logging module reporting a warning?<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US">In either case, I opened a bug (<a href="https://github.com/dreamhost/stevedore/issues/2">https://github.com/dreamhost/stevedore/issues/2</a>) to address this in stevedore.<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span lang="EN-US" style="font-size:10.5pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
</div>
<div>
<p class="MsoNormal"><span lang="EN-US"> <o:p></o:p></span></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm">
<p class="MsoNormal"><span lang="EN-US"><br>
Thanks<br>
--jyh<o:p></o:p></span></p>
</blockquote>
</div>
<p class="MsoNormal"><span lang="EN-US"><o:p> </o:p></span></p>
</div>
</div>
</body>
</html>