Thank your suggestions!<br><br>1. You are right, it just requires basic Posix filesystems APIs + Linux xattrs.<br>But you know that naming is very hard, so I temporarily name it to 'ext4'. In<br>the future, I will give it a new name.<br>
<br>2. I am not familiar with md5 and sha1, but md5 is only used for checksum, why <br>it is a bit dangerous? I'm confused :)<br><br>3. If qcow3 format is comming, I also need to implement qcow3 python library.<br>I only read snapshot data and metadata from image, qemu concurrent I/O will not <br>
modify snapshot data and metadata, so it is consistency.<br><br>4. I agree with you, it is best that we can export snapshot data and metadata from image by monitor command.<br><br><div class="gmail_quote">2012/10/31 <a href="mailto:hch@infradead.org">hch@infradead.org</a> <span dir="ltr"><<a href="mailto:hch@infradead.org" target="_blank">hch@infradead.org</a>></span><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Nice work!<br>
<br>
Some comments:<br>
<br>
I think the ext4 object backend should be renamed to 'Linux', as it just<br>
requires basic Posix filesystems APIs + Linux xattrs. In fact if it<br>
used and abstraction for the attributes it could easily support all<br>
modern Unix systems.<br>
<br>
Also md5 seems a bit dangerous for an identity hash, I'd suggest to<br>
use sha1 at least.<br>
<br>
One thing I am a bit concerned about is the direct manipulation of the<br>
qcow2 on disk format directly from cinder. How does this cope with<br>
updates to the format, e.g. from the qcow3 updates? Also how does it<br>
synchronize with concurrent I/O from qemu?<br>
<br>
I'd love to see this functionality added directly to qemu an exposed<br>
through the monitor.<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
_______________________________________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><br><span><font color="#888888">Rongze Zhu - ÖìÈÙÔó </font></span><br><span><font color="#888888"><span>Twitter: @metaxen<br></span><span style="font-size:13px;font-family:arial,sans-serif">Blog: <a href="http://blog.csdn.net/metaxen" target="_blank">http://blog.csdn.net/metaxen</a><br>
Weibo: </span></font></span><span><font color="#888888"><span style="font-size:13px;font-family:arial,sans-serif"><a href="http://weibo.com/metaxen" target="_blank">http://weibo.com/metaxen</a><br>Website: Try Free OpenStack in <a href="http://stacklab.org" target="_blank">http://www.stacklab.org</a><br>
<br></span></font></span><br>