Shouldn't the pep8 job have blocked the merge? It's showing green for pep8==1.3.3, which is what I have on my machine, but I'm seeing the same errors as below.<div><br></div><div><a href="https://jenkins.openstack.org/view/Keystone/job/gate-keystone-pep8/">https://jenkins.openstack.org/view/Keystone/job/gate-keystone-pep8/</a><br clear="all">
<div><br></div>-Dolph<br>
<br><br><div class="gmail_quote">On Thu, Sep 6, 2012 at 2:10 PM, Adam Young <span dir="ltr"><<a href="mailto:ayoung@redhat.com" target="_blank">ayoung@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
We merged a handful of files from common to Keystone, and ended up with some PEP8 warnings. I suspect it is because we have a newer version: pep8-1.3.3<br>
<br>
tox.ini in common has:<br>
deps = pep8==1.1<br>
<br>
<br>
<br>
keystone/openstack/common/<u></u>iniparser.py:57:13: E125 continuation line does not distinguish itself from next logical line<br>
(value[0] == "\"" or value[0] == "'")):<br>
^<br>
Continuation lines should align wrapped elements either vertically using<br>
Python's implicit line joining inside parentheses, brackets and braces, or<br>
using a hanging indent.<br>
<br>
When using a hanging indent the following considerations should be applied:<br>
<br>
- there should be no arguments on the first line, and<br>
<br>
- further indentation should be used to clearly distinguish itself as a<br>
continuation line.<br>
<br>
Okay: a = (\n)<br>
E123: a = (\n )<br>
<br>
Okay: a = (\n 42)<br>
E121: a = (\n 42)<br>
E122: a = (\n42)<br>
E123: a = (\n 42\n )<br>
E124: a = (24,\n 42\n)<br>
E125: if (a or\n b):\n pass<br>
E126: a = (\n 42)<br>
E127: a = (24,\n 42)<br>
E128: a = (24,\n 42)<br>
keystone/openstack/common/<u></u>timeutils.py:125:18: E128 continuation line under-indented for visual indent<br>
year=tyme['year'], hour=tyme['hour'], minute=tyme['minute'],<br>
^<br>
Continuation lines should align wrapped elements either vertically using<br>
Python's implicit line joining inside parentheses, brackets and braces, or<br>
using a hanging indent.<br>
<br>
When using a hanging indent the following considerations should be applied:<br>
<br>
- there should be no arguments on the first line, and<br>
<br>
- further indentation should be used to clearly distinguish itself as a<br>
continuation line.<br>
<br>
Okay: a = (\n)<br>
E123: a = (\n )<br>
<br>
Okay: a = (\n 42)<br>
E121: a = (\n 42)<br>
E122: a = (\n42)<br>
E123: a = (\n 42\n )<br>
E124: a = (24,\n 42\n)<br>
E125: if (a or\n b):\n pass<br>
E126: a = (\n 42)<br>
E127: a = (24,\n 42)<br>
E128: a = (24,\n 42)<br>
keystone/openstack/common/<u></u>timeutils.py:126:18: E121 continuation line indentation is not a multiple of four<br>
second=tyme['second'], microsecond=tyme['microsecond'<u></u>])<br>
^<br>
Continuation lines should align wrapped elements either vertically using<br>
Python's implicit line joining inside parentheses, brackets and braces, or<br>
using a hanging indent.<br>
<br>
When using a hanging indent the following considerations should be applied:<br>
<br>
- there should be no arguments on the first line, and<br>
<br>
- further indentation should be used to clearly distinguish itself as a<br>
continuation line.<br>
<br>
Okay: a = (\n)<br>
E123: a = (\n )<br>
<br>
Okay: a = (\n 42)<br>
E121: a = (\n 42)<br>
E122: a = (\n42)<br>
E123: a = (\n 42\n )<br>
E124: a = (24,\n 42\n)<br>
E125: if (a or\n b):\n pass<br>
E126: a = (\n 42)<br>
E127: a = (24,\n 42)<br>
E128: a = (24,\n 42)<br>
<br>
<br>
______________________________<u></u>_________________<br>
OpenStack-dev mailing list<br>
<a href="mailto:OpenStack-dev@lists.openstack.org" target="_blank">OpenStack-dev@lists.openstack.<u></u>org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-dev</a><br>
</blockquote></div><br></div>