<font face="Default Sans Serif,Verdana,Arial,Helvetica,sans-serif" size="2"> <span>Hi,<br><br>Quantum needs to use some codes in openstack common project, but pep8-1.3.3 (quantum project sticks to the latest pep8 version) complains many pep8 violations:<br>quantum/openstack/common/log.py:68:19: E121 continuation line indentation is not a multiple of four<br> 'amqplib=WARN',<br> ^<br>quantum/openstack/common/log.py:74:19: E123 closing bracket does not match indentation of opening bracket's line<br> ],<br> ^<br>quantum/openstack/common/log.py:91:5: E123 closing bracket does not match indentation of opening bracket's line<br> ]<br> ^<br>quantum/openstack/common/log.py:107:5: E123 closing bracket does not match indentation of opening bracket's line<br> ]<br> ^<br>quantum/openstack/common/log.py:211:39: E128 continuation line under-indented for visual indent<br> line.rstrip().splitlines())<br> ^<br>quantum/openstack/common/log.py:212:21: E128 continuation line under-indented for visual indent<br> for line in lines]<br> ^<br>quantum/openstack/common/log.py:251:17: E125 continuation line does not distinguish itself from next logical line<br> CONF.list_notifier_drivers):<br> ^<br>quantum/openstack/common/log.py:254:34: E127 continuation line over-indented for visual indent<br> 'error_notification',<br> ^<br>quantum/openstack/common/log.py:416:13: E125 continuation line does not distinguish itself from next logical line<br> CONF.logging_debug_format_suffix):<br> ^<br>quantum/openstack/common/rpc/__init__.py:50:80: E501 line too long (81 > 79 characters)<br> default=['quantum.openstack.common.exception', 'nova.exception'],<br> ^<br>quantum/openstack/common/rpc/impl_zmq.py:51:80: E501 line too long (85 > 79 characters)<br> default='quantum.openstack.common.rpc.matchmaker.MatchMakerLocalhost',<br> ^<br>quantum/openstack/common/notifier/api.py:39:5: E123 closing bracket does not match indentation of opening bracket's line<br> ]<br> ^<br>quantum/openstack/common/notifier/api.py:124:18: E121 continuation line indentation is not a multiple of four<br> _('%s not in valid priorities') % priority)<br> ^<br>quantum/openstack/common/notifier/api.py:131:20: E127 continuation line over-indented for visual indent<br> publisher_id=publisher_id,<br> ^<br>quantum/openstack/common/notifier/api.py:132:20: E127 continuation line over-indented for visual indent<br> event_type=event_type,<br> ^<br>quantum/openstack/common/notifier/api.py:133:20: E127 continuation line over-indented for visual indent<br> priority=priority,<br> ^<br>quantum/openstack/common/notifier/api.py:134:20: E127 continuation line over-indented for visual indent<br> payload=payload,<br> ^<br>quantum/openstack/common/notifier/api.py:135:20: E127 continuation line over-indented for visual indent<br> timestamp=str(timeutils.utcnow()))<br> ^<br>quantum/openstack/common/notifier/api.py:141:25: E127 continuation line over-indented for visual indent<br> locals())<br> ^<br>quantum/openstack/common/notifier/list_notifier.py:22:9: E128 continuation line under-indented for visual indent<br> default=['quantum.openstack.common.notifier.no_op_notifier'],<br> ^<br>quantum/openstack/common/notifier/list_notifier.py:23:9: E126 continuation line over-indented for hanging indent<br> help='List of drivers to send notifications')<br> ^<br>quantum/openstack/common/notifier/log_notifier.py:33:13: E126 continuation line over-indented for hanging indent<br> 'quantum.openstack.common.notification.%s' % message['event_type'])<br> ^<br>quantum/openstack/common/notifier/rabbit_notifier.py:25:9: E128 continuation line under-indented for visual indent<br> default=['notifications', ],<br> ^<br>quantum/openstack/common/notifier/rabbit_notifier.py:26:9: E126 continuation line over-indented for hanging indent<br> help='AMQP topic used for openstack notifications')<br></span><br style=""><font color="#ff0000">I don't know if I can update the openstack common project codes.</font><br>Thanks<br>Yong Sheng Gong<br></font>