<font face="Default Sans Serif,Verdana,Arial,Helvetica,sans-serif" size="2">Hi,<br>I am trying to introduce notifier and rpc modules into quantum from openstack.common project. Besides the previous pep8's problem, I found another one.<br><br>After I executed the update.sh in openstack.common with modules=cfg,exception,importutils,iniparser,jsonutils,policy,setup,notifier,timeutils,log,context,local,rpc,gettextutils,excutils<span><br>in quantum project's openstack-common.conf file, I cannot execute 'python setup.py install' in quantum project's top dir.<br><br>Beginning lines in quantum's setup.py are:<br>import setuptools<br><br>from quantum.openstack.common import setup<br><br>setup.write_vcsversion('quantum/vcsversion.py')<br><br>Obviously, it is expecting the </span><span>openstack.common.setup.</span><span>write_vcsversion() function, however which is gone in recent change of opoenstack.common project.</span><br><span><br>Should quantum project's setup.py change accordingly?<br><br>Thanks<br>Yong Sheng Gong<br></span><br><br><font color="#990099">-----Yun Mao <a class="moz-txt-link-rfc2396E" href="mailto:yunmao@gmail.com"><yunmao@gmail.com></a> wrote: -----</font><div style="padding-left: 5px;"><div style="padding-right: 0px; padding-left: 5px; border-left: 2px solid black;">To: OpenStack Development Mailing List <a class="moz-txt-link-rfc2396E" href="mailto:openstack-dev@lists.openstack.org"><openstack-dev@lists.openstack.org></a><br>From: Yun Mao <a class="moz-txt-link-rfc2396E" href="mailto:yunmao@gmail.com"><yunmao@gmail.com></a><br>Date: 07/14/2012 09:06PM<br>Subject: Re: [openstack-dev] pep8-1.3.3 result of openstack common codes<br><br><div><font face="Courier New,Courier,monospace" size="2">perhaps the pep8 check should ignore the openstack-common code. Thanks,<br><br>Yun<br><br>On Sat, Jul 14, 2012 at 5:24 AM, Yong Sheng Gong <a class="moz-txt-link-rfc2396E" href="mailto:gongysh@cn.ibm.com"><gongysh@cn.ibm.com></a> wrote:<br>> Hi,<br>><br>> Quantum needs to use some codes in openstack common project, but pep8-1.3.3<br>> (quantum project sticks to the latest pep8 version) complains many pep8<br>> violations:<br>> quantum/openstack/common/log.py:68:19: E121 continuation line indentation is<br>> not a multiple of four<br>> 'amqplib=WARN',<br>> ^<br>> quantum/openstack/common/log.py:74:19: E123 closing bracket does not match<br>> indentation of opening bracket's line<br>> ],<br>> ^<br>> quantum/openstack/common/log.py:91:5: E123 closing bracket does not match<br>> indentation of opening bracket's line<br>> ]<br>> ^<br>> quantum/openstack/common/log.py:107:5: E123 closing bracket does not match<br>> indentation of opening bracket's line<br>> ]<br>> ^<br>> quantum/openstack/common/log.py:211:39: E128 continuation line<br>> under-indented for visual indent<br>> line.rstrip().splitlines())<br>> ^<br>> quantum/openstack/common/log.py:212:21: E128 continuation line<br>> under-indented for visual indent<br>> for line in lines]<br>> ^<br>> quantum/openstack/common/log.py:251:17: E125 continuation line does not<br>> distinguish itself from next logical line<br>> CONF.list_notifier_drivers):<br>> ^<br>> quantum/openstack/common/log.py:254:34: E127 continuation line over-indented<br>> for visual indent<br>> 'error_notification',<br>> ^<br>> quantum/openstack/common/log.py:416:13: E125 continuation line does not<br>> distinguish itself from next logical line<br>> CONF.logging_debug_format_suffix):<br>> ^<br>> quantum/openstack/common/rpc/__init__.py:50:80: E501 line too long (81 > 79<br>> characters)<br>> default=['quantum.openstack.common.exception',<br>> 'nova.exception'],<br>><br>> ^<br>> quantum/openstack/common/rpc/impl_zmq.py:51:80: E501 line too long (85 > 79<br>> characters)<br>><br>> default='quantum.openstack.common.rpc.matchmaker.MatchMakerLocalhost',<br>><br>> ^<br>> quantum/openstack/common/notifier/api.py:39:5: E123 closing bracket does not<br>> match indentation of opening bracket's line<br>> ]<br>> ^<br>> quantum/openstack/common/notifier/api.py:124:18: E121 continuation line<br>> indentation is not a multiple of four<br>> _('%s not in valid priorities') % priority)<br>> ^<br>> quantum/openstack/common/notifier/api.py:131:20: E127 continuation line<br>> over-indented for visual indent<br>> publisher_id=publisher_id,<br>> ^<br>> quantum/openstack/common/notifier/api.py:132:20: E127 continuation line<br>> over-indented for visual indent<br>> event_type=event_type,<br>> ^<br>> quantum/openstack/common/notifier/api.py:133:20: E127 continuation line<br>> over-indented for visual indent<br>> priority=priority,<br>> ^<br>> quantum/openstack/common/notifier/api.py:134:20: E127 continuation line<br>> over-indented for visual indent<br>> payload=payload,<br>> ^<br>> quantum/openstack/common/notifier/api.py:135:20: E127 continuation line<br>> over-indented for visual indent<br>> timestamp=str(timeutils.utcnow()))<br>> ^<br>> quantum/openstack/common/notifier/api.py:141:25: E127 continuation line<br>> over-indented for visual indent<br>> locals())<br>> ^<br>> quantum/openstack/common/notifier/list_notifier.py:22:9: E128 continuation<br>> line under-indented for visual indent<br>> default=['quantum.openstack.common.notifier.no_op_notifier'],<br>> ^<br>> quantum/openstack/common/notifier/list_notifier.py:23:9: E126 continuation<br>> line over-indented for hanging indent<br>> help='List of drivers to send notifications')<br>> ^<br>> quantum/openstack/common/notifier/log_notifier.py:33:13: E126 continuation<br>> line over-indented for hanging indent<br>> 'quantum.openstack.common.notification.%s' %<br>> message['event_type'])<br>> ^<br>> quantum/openstack/common/notifier/rabbit_notifier.py:25:9: E128 continuation<br>> line under-indented for visual indent<br>> default=['notifications', ],<br>> ^<br>> quantum/openstack/common/notifier/rabbit_notifier.py:26:9: E126 continuation<br>> line over-indented for hanging indent<br>> help='AMQP topic used for openstack notifications')<br>><br>> I don't know if I can update the openstack common project codes.<br>> Thanks<br>> Yong Sheng Gong<br>><br>> _______________________________________________<br>> OpenStack-dev mailing list<br>> <a class="moz-txt-link-abbreviated" href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>><br><br>_______________________________________________<br>OpenStack-dev mailing list<br><a class="moz-txt-link-abbreviated" href="mailto:OpenStack-dev@lists.openstack.org">OpenStack-dev@lists.openstack.org</a><br><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br><br></font></div></div></div></font>