[openstack-dev] [swift] change in review policy: normally one +2 is sufficient

John Dickinson me at not.mn
Wed May 30 23:47:35 UTC 2018

During today's Swift team meeting[1], we discussed the idea of
relaxing review guidelines. We agreed the normal case is "one core
reviewer's approval is sufficient to land code".

We've long had a "one +2" policy for trivial and obviously correct
patches. Put simply, the old policy was one of "normally, two +2s are
needed, but if a reviewer feels it's not necessary to get another
review, go ahead and land it." Our new policy inverts that. Normally,
one +2 is needed, but a core may want to ask for additional reviews
for significant or complex patches.

When the Swift team gathers in Denver for the next PTG, we'll spend
some time revisiting this decision and reflect on the impact it has
had for the community and codebase.



More information about the OpenStack-dev mailing list