[openstack-dev] [tc][all] A culture change (nitpicking)
mnaser at vexxhost.com
Tue May 29 14:52:04 UTC 2018
On Tue, May 29, 2018 at 10:43 AM, Artom Lifshitz <alifshit at redhat.com> wrote:
> I dunno, there's a fine line to be drawn between getting a finished
> product that looks unprofessional (because of typos, English mistakes,
> etc), and nitpicking to the point of smothering and being
> counter-productive. One idea would be that, once the meat of the patch
> has passed multiple rounds of reviews and looks good, and what remains
> is only nits, the reviewer themselves take on the responsibility of
> pushing a new patch that fixes the nits that they found.
I'd just like to point out that what you perceive as a 'finished
product that looks unprofessional' might be already hard enough for a
contributor to achieve. We have a lot of new contributors coming from
all over the world and it is very discouraging for them to have their
technical knowledge and work be categorized as 'unprofessional'
because of the language barrier.
git-nit and a few minutes of your time will go a long way, IMHO.
> On Tue, May 29, 2018 at 9:55 AM, Julia Kreger
> <juliaashleykreger at gmail.com> wrote:
>> During the Forum, the topic of review culture came up in session after
>> session. During these discussions, the subject of our use of nitpicks
>> were often raised as a point of contention and frustration, especially
>> by community members that have left the community and that were
>> attempting to re-engage the community. Contributors raised the point
>> of review feedback requiring for extremely precise English, or
>> compliance to a particular core reviewer's style preferences, which
>> may not be the same as another core reviewer.
>> These things are not just frustrating, but also very inhibiting for
>> part time contributors such as students who may also be time limited.
>> Or an operator who noticed something that was clearly a bug and that
>> put forth a very minor fix and doesn't have the time to revise it over
>> and over.
>> While nitpicks do help guide and teach, the consensus seemed to be
>> that we do need to shift the culture a little bit. As such, I've
>> proposed a change to our principles in governance that attempts to
>> capture the essence and spirit of the nitpicking topic as a first
>> : https://review.openstack.org/570940
>> OpenStack Development Mailing List (not for usage questions)
>> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> Artom Lifshitz
> Software Engineer, OpenStack Compute DFG
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
More information about the OpenStack-dev