Open Stack

Hi, Akihiro

Thanks for the quick reply.

I agree with your opinion that BASE_XSTATIC_MODULES should not be modified.
It is much better to enhance horizon plugin settings,
 and I think maybe there could be one option like ADD_XSTATIC_MODULES.
This option adds the plugin's xstatic files in STATICFILES_DIRS.
I am considering to add a bug report to describe it at first, and give a
patch later maybe.
Is that ok with the Horizon team?

Best Regards.
Xinni

On Fri, Mar 9, 2018 at 11:47 PM, Akihiro Motoki <amotoki at gmail.com> wrote:

> Hi Xinni,
>
> 2018-03-09 12:05 GMT+09:00 Xinni Ge <xinni.ge1990 at gmail.com>:
> > Hello Horizon Team,
> >
> > I would like to hear about your opinions about how to add new xstatic
> > modules to horizon settings.
> >
> > As for Heat-dashboard project embedded 3rd-party files issue, thanks for
> > your advices in Dublin PTG, we are now removing them and referencing as
> new
> > xstatic-* libs.
>
> Thanks for moving this forward.
>
> > So we installed the new xstatic files (not uploaded as openstack official
> > repos yet) in our development environment now, but hesitate to decide
> how to
> > add the new installed xstatic lib path to STATICFILES_DIRS in
> > openstack_dashboard.settings so that the static files could be
> automatically
> > collected by *collectstatic* process.
> >
> > Currently Horizon defines BASE_XSTATIC_MODULES in
> > openstack_dashboard/utils/settings.py and the relevant static fils are
> added
> > to STATICFILES_DIRS before it updates any Horizon plugin dashboard.
> > We may want new plugin setting keywords ( something similar to
> ADD_JS_FILES)
> > to update horizon XSTATIC_MODULES (or directly update STATICFILES_DIRS).
>
> IMHO it is better to allow horizon plugins to add xstatic modules
> through horizon plugin settings. I don't think it is a good idea to
> add a new entry in BASE_XSTATIC_MODULES based on horizon plugin
> usages. It makes difficult to track why and where a xstatic module in
> BASE_XSTATIC_MODULES is used.
> Multiple horizon plugins can add a same entry, so horizon code to
> handle plugin settings should merge multiple entries to a single one
> hopefully.
> My vote is to enhance the horizon plugin settings.
>
> Akihiro
>
> >
> > Looking forward to hearing any suggestions from you guys, and
> > Best Regards,
> >
> > Xinni Ge
> >
> > ____________________________________________________________
> ______________
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:
> unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> >
>
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
>



-- 
葛馨霓 Xinni Ge
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20180312/a924da2e/attachment.html>