[openstack-dev] [oslo.db] [all] please DO NOT IMPORT from oslo_db.tests.* ! projects doing this need to revert ASAP

Doug Hellmann doug at doughellmann.com
Mon Feb 19 15:15:34 UTC 2018


Excerpts from Michael Bayer's message of 2018-02-19 10:00:59 -0500:
> Hi list -
> 
> Apparently Cinder was misled by my deprecations within the
> oslo_db.sqlalchemy.test_base package of DbFixture and DbTestCase, and
> in https://review.openstack.org/#/c/522290/ the assumption was made
> that these should be imported from oslo_db.tests.sqlalchemy.    This
> is an immense mistake on my part that I did not expect people to go
> looking for the same names elsewhere in private packages and now we
> have a serious downstream issue as these modules are not packaged, as
> well as the possibility that the oslo_db.tests. package is now locked
> in time and I have to add deprecations there also.
> 
> If anyone knows of projects (or feels like helping me search) that are
> importing *anything* from oslo_db.tests these must be reverted ASAP.
> 

If we have modules or classes we don't expect people to be importing
directly, we need to prefix the names with _ to comply with the naming
conventions we have previously told everyone to look for to recognize
private code.

I think it's safe to treat "tests" as an exception (after resolving
this case) but we should probably document that.

Doug



More information about the OpenStack-dev mailing list