[openstack-dev] [ironic][infra][qa] Jobs failing; pep8 not found

Jim Rollenhagen jim at jimrollenhagen.com
Fri Apr 20 13:05:23 UTC 2018


On Fri, Apr 20, 2018 at 7:33 AM, Jim Rollenhagen <jim at jimrollenhagen.com>
wrote:

> On Thu, Apr 19, 2018 at 3:21 PM, Doug Hellmann <doug at doughellmann.com>
> wrote:
>>
>>
>> Reading through that log more carefully, I see an early attempt to pin
>> pycodestyle <= 2.3.1 [1], followed later by pycodestyle == 2.4.0 being
>> pulled in as a dependency of flake8-import-order==0.12 when neutron's
>> test-requirements.txt is installed [2]. Then later when ironic's
>> test-requirements.txt is installed pycodestyle is downgraded to 2.3.1
>> [3].
>>
>> Reproducing those install & downgrade steps, I see that pycodestyle
>> 2.4.0 claims to own pep8.py but pycodestyle 2.3.1 does not [4]. So that
>> explains why pep8 is not re-installed when pycodestyle is downgraded.
>>
>
> Aha, interesting! That's a fun one. :)
>
> I think the real problem here is that we have linter dependencies listed
>> in the test-requirements.txt files for our projects, and they are
>> somehow being installed without the constraints.
>
>
> This is because they're in the blacklist, right?
>
>
>> I don't think they need
>> to be installed for devstack at all, so one way to fix it would be to
>> move those dependencies to the tox.ini section for running pep8, or to
>> have devstack look at the blacklisted packages and skip installing them.
>>
>
> Yeah, seems like either would work. With the latter, would devstack edit
> these out of test-requirements.txt before installing, I presume? The former
> seems less hacky, I'll proceed with that unless folks have objections.
>

Although... this would need to be done in every project installed from
source during the devstack run. I'm going to look into doing this in
devstack instead to avoid spending all day moving patches.

// jim
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20180420/05a08fde/attachment.html>


More information about the OpenStack-dev mailing list