[openstack-dev] [all][requirements] uncapping eventlet

Matthew Thode prometheanfire at gentoo.org
Fri Apr 6 16:34:33 UTC 2018


On 18-04-06 09:02:29, Jens Harbott wrote:
> 2018-04-05 19:26 GMT+00:00 Matthew Thode <prometheanfire at gentoo.org>:
> > On 18-04-05 20:11:04, Graham Hayes wrote:
> >> On 05/04/18 16:47, Matthew Thode wrote:
> >> > eventlet-0.22.1 has been out for a while now, we should try and use it.
> >> > Going to be fun times.
> >> >
> >> > I have a review projects can depend upon if they wish to test.
> >> > https://review.openstack.org/533021
> >>
> >> It looks like we may have an issue with oslo.service -
> >> https://review.openstack.org/#/c/559144/ is failing gates.
> >>
> >> Also - what is the dance for this to get merged? It doesn't look like we
> >> can merge this while oslo.service has the old requirement restrictions.
> >>
> >
> > The dance is as follows.
> >
> > 0. provide review for projects to test new eventlet version
> >    projects using eventlet should make backwards compat code changes at
> >    this time.
> 
> But this step is currently failing. Keystone doesn't even start when
> eventlet-0.22.1 is installed, because loading oslo.service fails with
> its pkg definition still requiring the capped eventlet:
> 
> http://logs.openstack.org/21/533021/4/check/legacy-requirements-integration-dsvm/7f7c3a8/logs/screen-keystone.txt.gz#_Apr_05_16_11_27_748482
> 
> So it looks like we need to have an uncapped release of oslo.service
> before we can proceed here.
> 

Ya, we may have to uncap and rely on upper-constraints to keep openstack
gate from falling over.  The new steps would be the following:

1. uncap eventlet https://review.openstack.org/559367
2. push uncapped eventlet out via requirements updates to all consumers
3. make review in requirements changing upper-constraints.txt for
   eventlet
4. projects depend on requirements change to do work on the new eventlet
   the patch generated should merge into project without the
   requirements change merged (this means the change should pass in the
   dependant review (to test 0.22.1) AND in a separate non-dependant
   review (test the current constraint).  You would merge the
   non-dependant once both reviews are passing.
5. Once some non-determined set of projects work with the new eventlet
   we'd merge the updated upper-constraint into requirements.

steps 2 and 3 can happen in parallel, projects can move to step 4 after
step 3 is done (step 2 is only needed for their project and their
project's dependencies).

There is bound to be projects that will break as they didn't take the
opportunity to fix themselves, but this should help reduce breakage.  I
suggest a 1 month deadline after step 2/3 is considered complete before
step 5 is performed.

-- 
Matthew Thode (prometheanfire)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.openstack.org/pipermail/openstack-dev/attachments/20180406/761e9a8e/attachment.sig>


More information about the OpenStack-dev mailing list