[openstack-dev] [nova][oslo] what to do with problematic mocking in nova unit tests

Doug Hellmann doug at doughellmann.com
Tue Apr 3 17:44:19 UTC 2018


Excerpts from Eric Fried's message of 2018-03-31 16:12:22 -0500:
> Hi Doug, I made this [2] for you.  I tested it locally with oslo.config
> master, and whereas I started off with a slightly different set of
> errors than you show at [1], they were in the same suites.  Since I
> didn't want to tox the world locally, I went ahead and added a
> Depends-On from [3].  Let's see how it plays out.
> 
> >> [1]
> http://logs.openstack.org/12/557012/1/check/cross-nova-py27/37b2a7c/job-output.txt.gz#_2018-03-27_21_41_09_883881
> [2] https://review.openstack.org/#/c/558084/
> [3] https://review.openstack.org/#/c/557012/
> 
> -efried

Thanks, Eric! That looks like it should do the trick. I'll give it
a try.

Doug

> 
> On 03/30/2018 06:35 AM, Doug Hellmann wrote:
> > Anyone?
> > 
> >> On Mar 28, 2018, at 1:26 PM, Doug Hellmann <doug at doughellmann.com> wrote:
> >>
> >> In the course of preparing the next release of oslo.config, Ben noticed
> >> that nova's unit tests fail with oslo.config master [1].
> >>
> >> The underlying issue is that the tests mock things that oslo.config
> >> is now calling as part of determining where options are being set
> >> in code. This isn't an API change in oslo.config, and it is all
> >> transparent for normal uses of the library. But the mocks replace
> >> os.path.exists() and open() for the entire duration of a test
> >> function (not just for the isolated application code being tested),
> >> and so the library behavior change surfaces as a test error.
> >>
> >> I'm not really in a position to go through and clean up the use of
> >> mocks in those (and other?) tests myself, and I would like to not
> >> have to revert the feature work in oslo.config, especially since
> >> we did it for the placement API stuff for the nova team.
> >>
> >> I'm looking for ideas about what to do.
> >>
> >> Doug
> >>
> >> [1] http://logs.openstack.org/12/557012/1/check/cross-nova-py27/37b2a7c/job-output.txt.gz#_2018-03-27_21_41_09_883881
> >>
> >> __________________________________________________________________________
> >> OpenStack Development Mailing List (not for usage questions)
> >> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> >> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> > 
> > 
> > __________________________________________________________________________
> > OpenStack Development Mailing List (not for usage questions)
> > Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> > http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev
> > 
> 



More information about the OpenStack-dev mailing list