[openstack-dev] Garbage patches for simple typo fixes
anteaya at anteaya.info
Mon Sep 25 16:12:23 UTC 2017
On 2017-09-22 06:11 PM, Mike Perez wrote:
> On 21:21 Sep 21, Matt Riedemann wrote:
>> I just wanted to highlight to people that there seems to be a series of
>> garbage patches in various projects  which are basically doing things
>> like fixing a single typo in a code comment, or very narrowly changing http
>> to https in links within docs.
>> Also +1ing ones own changes.
>> I've been trying to snuff these out in nova, but I see it's basically a
>> pattern widespread across several projects.
>> This is the boilerplate comment I give with my -1, feel free to employ it
>> "Sorry but this isn't really a useful change. Fixing typos in code comments
>> when the context is still clear doesn't really help us, and mostly seems
>> like looking for padding stats on stackalytics. It's also a drain on our CI
>> If you fixed all of the typos in a single module, or in user-facing
>> documentation, or error messages, or something in the logs, or something
>> that actually doesn't make sense in code comments, then maybe, but this
>> isn't one of those things."
>> I'm not trying to be a jerk here, but this is annoying to the point I felt
>> the need to say something publicly.
>>  https://review.openstack.org/#/q/author:%255E.*inspur.*
> I agree with the frustration here. It was mentioned earlier in the thread the
> top 5 wanted  is a good step in the right direction. I think also the
> efforts on the contributor portal  are going to be a helpful link to send
> people when they make mistakes.
> I'm sure some of the people who haven't had this communicated to them yet
> aren't aware, so we should all be aware as demonstrated in Matt's boilerplate
> comment to be nice when communicating.
>  - http://governance.openstack.org/tc/reference/top-5-help-wanted.html
When I click this link I see two items. Perhaps the list can be named
'help wanted list' and the point about it being the top 5 or having a
maximum of 5 items can be made in the text. Having a top 5 list with 2
items may confuse the audience folks are trying to redirect here.
>  - http://lists.openstack.org/pipermail/openstack-dev/2017-September/122534.html
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the OpenStack-dev