Open Stack

On 7/17/2017 6:31 PM, melanie witt wrote:
> On Tue, 18 Jul 2017 09:22:31 +0900, Ghanshyam Mann wrote:
>> Yes, this is same case when we do fetch patch set using git checkout,
>> i do not think its something to do with gite review -d.
> 
> Doing that shouldn't change the author, at least in my experience. I 
> constantly 'git fetch' or 'git review -d <change>' to fetch a patch, 
> update it, and push a new revision. When I do that, the author stays the 
> same but it shows me as the "Committer".
> 
> I have seen the behavior Matt describes happen to other people though 
> and I would guess it has something to do with the rebase. Though I feel 
> like I've also rebased other people's changes and it didn't change the 
> Author, it only changed the Committer to me.
> 
> -melanie
> 
> __________________________________________________________________________
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
> http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev

I figured out the pattern when this happens to change the author.

1. git review -d
2. git rebase -i master
3. <merge conflict>
4. fix merge conflict
5. git add <files>
6. git commit
7. git rebase --continue

It's the merge conflict + git commit during the rebase that changes the 
author for me.

-- 

Thanks,

Matt