[openstack-dev] [dib][heat] dib-utils/dib-run-parts/dib v2 concern
iwienand at redhat.com
Fri Mar 17 06:08:34 UTC 2017
On 03/17/2017 03:46 AM, Steven Hardy wrote:
> (undercloud) [stack at undercloud ~]$ rpm -qf /usr/bin/dib-run-parts
> (undercloud) [stack at undercloud ~]$ rpm -qf /bin/dib-run-parts
/bin is a link to /usr/bin? So I think this is the same and this is
the dib-run-parts as pacakged by dib-utils.
> (undercloud) [stack at undercloud ~]$ rpm -qf /usr/lib/python2.7/site-packages/diskimage_builder/lib/dib-run-parts
This is dib's "private" copy. As I mentioned in the other mail, the
intention was to vendor this so we could re-write for dib-specific
needs if need be (given future requirements such as running in
restricted container environments). I believe having dib exporting
this was an (my) oversight. I have proposed  to remove this.
> (undercloud) [stack at undercloud ~]$ rpm -qf /usr/local/bin/dib-run-parts
> file /usr/local/bin/dib-run-parts is not owned by any package
This would come from the image build process. We copy dib-run-parts
into the chroot to run in-target scripts  but we never actually
remove it. This seems to me to also be a bug and I've proposed  to
run this out of /tmp and clean it up.
> But the exciting thing from a rolling-out-bugfixes perspective is that the
> one actually running via o-r-c isn't either of the packaged versions (doh!)
> so we probably need to track down which element is installing it.
> This is a little OT for this thread (sorry), but hopefully provides more
> context around my concerns about creating another fork etc.
I don't want us to get a little too "left-pad"  with this 95ish
lines of shell :) I think this stack clears things up.
- dib version should be vendored; not in path & not exported 
- unnecessary /usr/local/bin version removed 
- dib-utils provides /usr/bin/ version
Cross-ports between the vendored dib version and dib-utils should be
trivial given what it is. If dib wants to rewrite it's vendored
version, or remove it completely, this will not affect anyone
depending on dib-utils.
 https://review.openstack.org/446285 (dib: do not provide dib-run-parts)
 https://review.openstack.org/446769 (dib: run chroot dib-run-parts out of /tmp)
More information about the OpenStack-dev