[openstack-dev] [nova] question on , quience use call and unquience use cast
yikunkero at gmail.com
Thu Dec 21 09:43:36 UTC 2017
Something I found, FYI:
The commit history in here: https://review.openstack.org/#/c/138795
I noticed that the unquience change call to cast in PS5 and PS6:
and some comments on
According history comments, the reason of "use cast for unquience": it adds
_wait_for_snapshots_completion operation on unquience method in PS6,
it will cause the rpc timeout before snapshot finished if we use call rpc.
The reason of "use call for quience", I think is just quience is a short
operation, no need to change cast to call?
In the other word, call or cast is okay for quience operation, so, he
didn't change it.
Hope this helps, : )
Mail: yikunkero at gmail.com
Tel: (+86) 13572822142
2017-12-21 16:48 GMT+08:00 Chen CH Ji <jichenjc at cn.ibm.com>:
> During review https://review.openstack.org/#/c/529278/2 ,some question on
> the method for quience/unquience
> use call for quience
> use cast for unquience
> just curious ,any special purpose for use different type here?
> Best Regards!
> Kevin (Chen) Ji 纪 晨
> Engineer, zVM Development, CSTL
> Notes: Chen CH Ji/China/IBM at IBMCN Internet: jichenjc at cn.ibm.com
> Phone: +86-10-82451493 <+86%2010%208245%201493>
> Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District,
> Beijing 100193, PRC
> OpenStack Development Mailing List (not for usage questions)
> Unsubscribe: OpenStack-dev-request at lists.openstack.org?subject:unsubscribe
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the OpenStack-dev